Minor error in makefile

[Guest Enverex]

At almost the very bottom:

 

install-data-hook:
	rm -f $(bindir)/plugins/libgemrb_core.so
	mkdir -p $(bindir)/Cache 2>/dev/null
	rm -rf $(bindir)/Cache/*

 

Should be:

 

install-data-hook:
	rm -f $(bindir)/plugins/libgemrb_core.so
	mkdir -p $(DESTDIR)/$(bindir)/Cache 2>/dev/null
	rm -rf $(bindir)/Cache/*

 

The original works normally, but things that build the program strictly will barf if it tries to do what it does originally (basically writing where it shouldn't).

 

Ex.

[Avenger]

At almost the very bottom:

 

install-data-hook:
	rm -f $(bindir)/plugins/libgemrb_core.so
	mkdir -p $(bindir)/Cache 2>/dev/null
	rm -rf $(bindir)/Cache/*

 

Should be:

 

install-data-hook:
	rm -f $(bindir)/plugins/libgemrb_core.so
	mkdir -p $(DESTDIR)/$(bindir)/Cache 2>/dev/null
	rm -rf $(bindir)/Cache/*

 

The original works normally, but things that build the program strictly will barf if it tries to do what it does originally (basically writing where it shouldn't).

 

Ex.

 

Shouldn't the rm work on the same directory mkdir just created?

[Guest Guest]

At almost the very bottom:

 

install-data-hook:
	rm -f $(bindir)/plugins/libgemrb_core.so
	mkdir -p $(bindir)/Cache 2>/dev/null
	rm -rf $(bindir)/Cache/*

 

Should be:

 

install-data-hook:
	rm -f $(bindir)/plugins/libgemrb_core.so
	mkdir -p $(DESTDIR)/$(bindir)/Cache 2>/dev/null
	rm -rf $(bindir)/Cache/*

 

The original works normally, but things that build the program strictly will barf if it tries to do what it does originally (basically writing where it shouldn't).

 

Ex.

 

Shouldn't the rm work on the same directory mkdir just created?

 

Yup. forgot that bit. Piping errors to /dev/null is naughty too though