Jump to content

Bugs Reports - v8


Recommended Posts

I have investigated the Solar sequence. The code is as follows:

 

IF ~~ THEN BEGIN 27 // from: 26.0 22.0 19.0
 SAY #67865 /* ~The choice is difficult, but these are your two options, Bhaalspawn.  This is where your destiny is realized, and your future begins.~ [SOLAR101] */
 IF ~True()~ THEN GOTO 28
 IF ~IsValidForPartyDialog("Valygar")
Global("ValygarRomanceActive","GLOBAL",2)~ THEN EXTERN ~VALYG25J~ 3
 IF ~IsValidForPartyDialog("Anomen")
Global("AnomenRomanceActive","GLOBAL",2)~ THEN EXTERN ~ANOME25J~ 11
 IF ~IsValidForPartyDialog("Viconia")
Global("ViconiaRomanceActive","GLOBAL",2)~ THEN EXTERN ~VICON25J~ 8
 IF ~IsValidForPartyDialog("Aerie")
Global("AerieRomanceActive","GLOBAL",2)~ THEN EXTERN ~AERIE25J~ 9
 IF ~IsValidForPartyDialog("Jaheira")
Global("JaheiraRomanceActive","GLOBAL",2)~ THEN EXTERN ~JAHEI25J~ 9
 IF ~IsValidForPartyDialog("Valygar")
!Global("ValygarRomanceActive","GLOBAL",2)~ THEN EXTERN ~VALYG25J~ 2
 IF ~IsValidForPartyDialog("Anomen")
!Global("AnomenRomanceActive","GLOBAL",2)~ THEN EXTERN ~ANOME25J~ 10
 IF ~IsValidForPartyDialog("Viconia")
!Global("ViconiaRomanceActive","GLOBAL",2)~ THEN EXTERN ~VICON25J~ 6
 IF ~IsValidForPartyDialog("Aerie")
!Global("AerieRomanceActive","GLOBAL",2)~ THEN EXTERN ~AERIE25J~ 7
 IF ~IsValidForPartyDialog("Jaheira")
!Global("JaheiraRomanceActive","GLOBAL",2)~ THEN EXTERN ~JAHEI25J~ 7
 IF ~IsValidForPartyDialog("Imoen2")~ THEN EXTERN ~IMOEN25J~ 15
 IF ~IsValidForPartyDialog("Sarevok")
!Alignment("Sarevok",MASK_EVIL)~ THEN EXTERN ~SAREV25J~ 2
 IF ~IsValidForPartyDialog("Sarevok")
Alignment("Sarevok",MASK_EVIL)~ THEN EXTERN ~SAREV25J~ 3
 IF ~IsValidForPartyDialog("Minsc")~ THEN EXTERN ~MINSC25J~ 0
 IF ~IsValidForPartyDialog("Nalia")~ THEN EXTERN ~NALIA25J~ 1
 IF ~IsValidForPartyDialog("HaerDalis")~ THEN EXTERN ~HAERD25J~ 1
 IF ~IsValidForPartyDialog("Jan")~ THEN EXTERN ~JAN25J~ 3
 IF ~IsValidForPartyDialog("Cernd")~ THEN EXTERN ~CERND25J~ 0
 IF ~IsValidForPartyDialog("Mazzy")~ THEN EXTERN ~MAZZY25J~ 0
 IF ~IsValidForPartyDialog("Edwin")~ THEN EXTERN ~EDWIN25J~ 0
 IF ~IsValidForPartyDialog("Korgan")~ THEN EXTERN ~KORGA25J~ 2
 IF ~IsValidForPartyDialog("Keldorn")~ THEN EXTERN ~KELDO25J~ 0
 IF ~Global("Sola_TOB_End","GLOBAL",0)
InParty("Sola")
!Global("SolaTalk","GLOBAL",-1)
~ THEN DO ~SetGlobal("Sola_TOB_End","GLOBAL",1)~ EXTERN ~SOLA~ 616
END

...

IF ~~ THEN BEGIN 29 // from: 28.2
 SAY #68068 /* ~As you wish, though it brings me no pleasure to unleash such an evil onto the cosmos.  You are wicked, Bhaalspawn, and your time as a power will be a difficult one, I swear.~ [SOLAR103] */
 IF ~True()~ THEN GOTO 33
 IF ~IsValidForPartyDialog("Valygar")
Global("ValygarRomanceActive","GLOBAL",2)~ THEN EXTERN ~VALYG25J~ 11
 IF ~IsValidForPartyDialog("Anomen")
Global("AnomenRomanceActive","GLOBAL",2)~ THEN EXTERN ~ANOME25J~ 20
 IF ~IsValidForPartyDialog("Viconia")
Global("ViconiaRomanceActive","GLOBAL",2)~ THEN EXTERN ~VICON25J~ 18
 IF ~IsValidForPartyDialog("Aerie")
Global("AerieRomanceActive","GLOBAL",2)~ THEN EXTERN ~AERIE25J~ 20
 IF ~IsValidForPartyDialog("Jaheira")
Global("JaheiraRomanceActive","GLOBAL",2)~ THEN EXTERN ~JAHEI25J~ 18
 IF ~IsValidForPartyDialog("Imoen2")~ THEN EXTERN ~IMOEN25J~ 18
 IF ~IsValidForPartyDialog("Sarevok")
Alignment("Sarevok",MASK_EVIL)~ THEN EXTERN ~SAREV25J~ 4
 IF ~IsValidForPartyDialog("Sarevok")
!Alignment("Sarevok",MASK_EVIL)~ THEN EXTERN ~SAREV25J~ 6
END

IF ~~ THEN BEGIN 30 // from: 28.1
 SAY #68069 /* ~As you wish... though the thought of you succumbing to the temptations of Bhaal's foul taint brings me no pleasure.  We shall see what manner of power you become, in time.~ [SOLAR104] */
 IF ~True()~ THEN GOTO 33
 IF ~IsValidForPartyDialog("Valygar")
Global("ValygarRomanceActive","GLOBAL",2)~ THEN EXTERN ~VALYG25J~ 11
 IF ~IsValidForPartyDialog("Anomen")
Global("AnomenRomanceActive","GLOBAL",2)~ THEN EXTERN ~ANOME25J~ 20
 IF ~IsValidForPartyDialog("Viconia")
Global("ViconiaRomanceActive","GLOBAL",2)~ THEN EXTERN ~VICON25J~ 18
 IF ~IsValidForPartyDialog("Aerie")
Global("AerieRomanceActive","GLOBAL",2)~ THEN EXTERN ~AERIE25J~ 20
 IF ~IsValidForPartyDialog("Jaheira")
Global("JaheiraRomanceActive","GLOBAL",2)~ THEN EXTERN ~JAHEI25J~ 18
 IF ~IsValidForPartyDialog("Imoen2")~ THEN EXTERN ~IMOEN25J~ 18
 IF ~IsValidForPartyDialog("Sarevok")
Alignment("Sarevok",MASK_EVIL)~ THEN EXTERN ~SAREV25J~ 4
 IF ~IsValidForPartyDialog("Sarevok")
!Alignment("Sarevok",MASK_EVIL)~ THEN EXTERN ~SAREV25J~ 6
END

IF ~~ THEN BEGIN 31 // from: 28.0
 SAY #68070 /* ~As you wish.  You have proven to us all that the power in your blood is yours to command... it does not command you.  I shall be proud to stand by you in a place of power among the heavens.~ [SOLAR105] */
 IF ~True()~ THEN GOTO 33
 IF ~IsValidForPartyDialog("Valygar")
Global("ValygarRomanceActive","GLOBAL",2)~ THEN EXTERN ~VALYG25J~ 11
 IF ~IsValidForPartyDialog("Anomen")
Global("AnomenRomanceActive","GLOBAL",2)~ THEN EXTERN ~ANOME25J~ 20
 IF ~IsValidForPartyDialog("Viconia")
Global("ViconiaRomanceActive","GLOBAL",2)~ THEN EXTERN ~VICON25J~ 18
 IF ~IsValidForPartyDialog("Aerie")
Global("AerieRomanceActive","GLOBAL",2)~ THEN EXTERN ~AERIE25J~ 20
 IF ~IsValidForPartyDialog("Jaheira")
Global("JaheiraRomanceActive","GLOBAL",2)~ THEN EXTERN ~JAHEI25J~ 18
 IF ~IsValidForPartyDialog("Imoen2")~ THEN EXTERN ~IMOEN25J~ 18
 IF ~IsValidForPartyDialog("Sarevok")
Alignment("Sarevok",MASK_EVIL)~ THEN EXTERN ~SAREV25J~ 4
 IF ~IsValidForPartyDialog("Sarevok")
!Alignment("Sarevok",MASK_EVIL)~ THEN EXTERN ~SAREV25J~ 6
END

IF ~~ THEN BEGIN 32 // from: 28.3
 SAY #68071 /* ~Then you shall begin life anew, mortal, without the taint of your sire upon your soul... and the essence of Bhaal shall forever be hidden.  You have done well, and freedom shall be your reward.~ [SOLAR106] */
 IF ~True()~ THEN GOTO 33
 IF ~IsValidForPartyDialog("Valygar")
Global("ValygarRomanceActive","GLOBAL",2)~ THEN EXTERN ~VALYG25J~ 12
 IF ~IsValidForPartyDialog("Anomen")
Global("AnomenRomanceActive","GLOBAL",2)~ THEN EXTERN ~ANOME25J~ 21
 IF ~IsValidForPartyDialog("Viconia")
Global("ViconiaRomanceActive","GLOBAL",2)~ THEN EXTERN ~VICON25J~ 19
 IF ~IsValidForPartyDialog("Aerie")
Global("AerieRomanceActive","GLOBAL",2)~ THEN EXTERN ~AERIE25J~ 21
 IF ~IsValidForPartyDialog("Jaheira")
Global("JaheiraRomanceActive","GLOBAL",2)~ THEN EXTERN ~JAHEI25J~ 19
 IF ~IsValidForPartyDialog("Imoen2")~ THEN EXTERN ~IMOEN25J~ 19
 IF ~IsValidForPartyDialog("Sarevok")
Alignment("Sarevok",MASK_EVIL)~ THEN EXTERN ~SAREV25J~ 5
 IF ~IsValidForPartyDialog("Sarevok")
!Alignment("Sarevok",MASK_EVIL)~ THEN EXTERN ~SAREV25J~ 7
END

 

In other words, only one NPC has the chance to interject, the one who is in the party and who is the LAST in the sequence, instead of all of them saying their tidbit.

 

In other words, if you have Sarevok in the party, he'll always be the one to interject, and no other NPC will have a chance to say anything. So, really, I am just duplicating the same action with Kivan. Obviously, he ends up as the one who says his piece, since he is a modded NPC, and his reply goes last.

 

I can either remove Kivan's interjection, keep it consistent withthe original game, or 'correct' the game and add a 'chain' sequence to include all the NPC remarks so they will all comment before/after Kivan. That will potentially put me into a conflict with the other mods, which might want to try to do the same (?) - I see that Solaufein for one does not, he is doing the same thing that Kivan does presently.

 

So, opinions?

 

I will repost it separately too, because I am baffled as to what is the best thing to do.

Link to comment

I have no idea about Sarevok and Solaufein, since I've never played the game with them in my party, but I think Kelsey has a different code here, and his interjection does not lead to the other NPCs remaining silent (same goes for when I played ToB with a BioWare only party, consisting of Anomen, Keldorn, Minsc, Jaheira and the annoying Imoen - all of them got to say their part). Also, I obviously do not know much about coding. Forgive me, I am unaware of the ethics in such a situation, so apologies if posting Kelsey's code is a faux pas from my part (and, Domi, please feel free to remove it). Here it is:

 

/* FINSOL01 sequence : advice */

 

INTERJECT_COPY_TRANS FINSOL01 27 FWKintfinsol271

== J#KLS25J IF ~IsValidForPartyDialog("J#Kelsey") !Global("J#KelseyRomanceActive","GLOBAL",2)~ THEN @110

== J#KLS25J IF ~IsValidForPartyDialog("J#Kelsey") !Global("J#KelseyRomanceActive","GLOBAL",2)~ THEN @111

== J#KLS25J IF ~IsValidForPartyDialog("J#Kelsey") !Global("J#KelseyRomanceActive","GLOBAL",2)~ THEN @112

== J#KLS25J IF ~IsValidForPartyDialog("J#Kelsey") !Global("J#KelseyRomanceActive","GLOBAL",2)~ THEN @113

END

 

EXTEND_BOTTOM FINSOL01 27

IF ~IsValidForPartyDialog("J#Kelsey")

Global("J#KelseyRomanceActive","GLOBAL",2)

Global("FWKIstay1","GLOBAL",0)~ THEN DO ~SetGlobal("FWKIstay1","GLOBAL",1)~ EXTERN J#KLS25J stay1

END

 

EXTEND_BOTTOM FINSOL01 29

IF ~IsValidForPartyDialog("J#Kelsey")

Global("J#KelseyRomanceActive","GLOBAL",2)

Global("FWKIleaving1","GLOBAL",0)~ THEN DO

~SetGlobal("FWKIleaving1","GLOBAL",1)~ EXTERN J#KLS25J leaving1

END

 

EXTEND_BOTTOM FINSOL01 30

IF ~IsValidForPartyDialog("J#Kelsey")

Global("J#KelseyRomanceActive","GLOBAL",2)

Global("FWKIleaving1","GLOBAL",0)~ THEN DO

~SetGlobal("FWKIleaving1","GLOBAL",1)~ EXTERN J#KLS25J leaving1

END

 

EXTEND_BOTTOM FINSOL01 31

IF ~IsValidForPartyDialog("J#Kelsey")

Global("J#KelseyRomanceActive","GLOBAL",2)

Global("FWKIleaving1","GLOBAL",0)~ THEN DO

~SetGlobal("FWKIleaving1","GLOBAL",1)~ EXTERN J#KLS25J leaving1

END

 

EXTEND_BOTTOM FINSOL01 32

IF ~IsValidForPartyDialog("J#Kelsey")

Global("J#KelseyRomanceActive","GLOBAL",2)

Global("FWKIendstay1","GLOBAL",0)~ THEN DO

~SetGlobal("FWKIendstay1","GLOBAL",1)~ EXTERN J#KLS25J endstay1

END

 

APPEND J#KLS25J

IF ~~ THEN BEGIN stay1

SAY @114 = @115 = @116

IF ~ReputationGT(Player1,10)~ THEN GOTO stay2

IF ~ReputationLT(Player1,11)~ THEN GOTO stay3

END

 

IF ~~ THEN BEGIN stay2

SAY @117

IF ~~ THEN GOTO stay4

END

 

IF ~~ THEN BEGIN stay3

SAY @118

IF ~~ THEN GOTO stay4

END

 

IF ~~ THEN BEGIN stay4end

SAY @126

IF ~~ THEN REPLY @127 GOTO stay11

IF ~~ THEN REPLY @128 GOTO stay10

IF ~~ THEN REPLY @129 GOTO stay11

IF ~~ THEN REPLY @130 GOTO stay10

END

 

IF ~~ THEN BEGIN stay10

SAY @131 = @132

COPY_TRANS FINSOL01 27

END

 

IF ~~ THEN BEGIN stay11end

SAY @140

COPY_TRANS FINSOL01 27

END

 

... And some other similar bulks of code taking into account other options for the PC (pregnancy, ascension and so on), but I believe the above is the most relevant part (with the repeated caveat that I am an amateur with coding, and the repeated apology to jcompton for posting the code to begin with). What do you think, is this why Kelsey's interjections at the end do not overwrite the others?

Link to comment

I don't understand why JC is using the first block of code, on 27 in combination with the EB. But if COPY_TRANS works to route back into the sequence, that should be Okay, though didn't it cause problems before with the character saying a line twice? Don't remember. I will just add COPY_TRANS and keep my fingers crossed that it worked.

Link to comment
Guest Covdrummer

Hey i found a typo. In the astral prison just after you defeat the master of the thralls, Kivan starts a dialogue and it goes along the lines of "humility is a treat of man" or something very similar, anyway im guessing that should be "trait". It appeared twice in that sequence of dialogue.

Also i thought that was a nice little dialogue showing his opinions towards slavery-nice job

Link to comment

Okay, folks! This weekend is designated as Kivan's Days, and I will try to get through all the bugs and tagg the entire mod for the voice actor. I plan to have both voicing and bug-fixes included into V9. Cheers!

Link to comment

Okay, went through the bug reports here and in the back, gotta test those ITJ's now and then it's to the sounnd-tagging/sound recording. Is anyone running Kivan atm and Okay to alpha-test the version for me sometime this month before the sound is added? :crazyeyes: What I am looking to see are:

 

-Kivan gives you identified arrows

-Anomen's conflict triggers after PC declared her love for Anomen in Sarek's house, and Anomen's romance shuts down after that, while Kivan's resumes (Kivan love goes to 0 if not specified Kivan, to 15 if specified Kivan

-Kivan points Aphril out when he sees her

-Kivan's interjection in Adrik's quest will not show up now, for sure.

-Interjections by other chars at the Throne work.

-Jaheira does not say Imoen's lines in the ToB bnater with Deheriana

Link to comment

I could do it, Domi. Well, except for the Deheriana part, since, as I see it, most of the things you want checked are related to Kivan's romance with the PC.

 

Though, could you perhaps specify exactly the plan for the Anomen thing? I mean, is the PC supposed to romance him and then dump him?

Link to comment

Sorry for the double post. :crazyeyes:

 

This is not a bug report; I only wanted to say that, on my computer, Kivan's LT theme (the one from PS:T, Deionarra's Theme, not the Karelia song) is very hard to hear, as it has been recorded in a much lower volume than the rest of the BG2 Soundtrack. I am not sure if this is just for me, or for everyone, but I wanted to let you know, just in case.

 

That being said, if anyone else is having this issue, I have found a place where one can get the same song at a better quality. You can find it here (right click on "Download to Computer" and "Save Target As"). The way I hear it (though, of course, I am in no way an expert), the difference between the current Kivan song and the one I linked you to is that the latter has a slightly louder volume and is better balanced between my two speakers.

 

Please remove this post if its content is inappropriate.

Link to comment

Hi, thank you. I will redownload the track :groucho:

 

As for Anomen's, that chat is intended for the characters who did went through Anomen's romance and told Anomen in Saerk's house that they love him to death to stop him from killing people. I always felt that this confession was forced, and I disliked how it worked, so I wanted to give a subtle chance to go back on your words after the conflict is resolved and Anomen haven't killed anyone because PC didn't say she loved him.

 

Thank you, I want to sort out one issue in TP2, and then I can send you a linkie :crazyeyes:

Link to comment
Hi, thank you. I will redownload the track

 

You're welcome. I've just tested it on my computer at home as well (I was at work earlier), and the sound is indeed better. I hope you like it. :groucho:

 

As for Anomen's, that chat is intended for the characters who did went through Anomen's romance and told Anomen in Saerk's house that they love him to death to stop him from killing people. I always felt that this confession was forced, and I disliked how it worked, so I wanted to give a subtle chance to go back on your words after the conflict is resolved and Anomen haven't killed anyone because PC didn't say she loved him.

 

Ah, okay, I understood. Thanks for the explanation; it definitely sounds lovely to have more roleplaying options. I can definitely check that too. After all, I do like playing through Anomen's romance (yeah, I know...), and I always felt that the way his RA went to 2 without an option to prevent it (other than the console or previous rude replies) was a little bit annoying, to say the least.

 

Thank you, I want to sort out one issue in TP2, and then I can send you a linkie

 

Awesome, thank you. I'll look forward to it. :crazyeyes:

Link to comment

Archived

This topic is now archived and is closed to further replies.

×
×
  • Create New...