bg 2 : thac0 constantly decreasing

[MouToN]

I've just recruited Haer'Dalis (overriden by bg2fixpack) and when I checked his stats, his base thac0 was -100. Actually few "print GetPlayerStat(6, IE_TOHIT, 1)" show that it's constantly decreasing (well I guess it is limited by the variable type) even after setting it to a normal one (15, 10 or whatever) so it's more -1500 or -2000... oh wait, it's -5000 now!

 

ShadowKeeper shows that haer*.cre all have a +1 thac0 bonus in the "Affects" tab (certainly an instant/permanent one, but that's just a guess as I am no specialist).

 

Here is what CTRL+M gives me.

 

[Actor/DEBUG]: Debugdump of Actor Haer-Dalis (Haer-Dalis, Haer-Dalis):

Scripts: haerdali <none> <none> <none> default <none> <none> dplayer2

Area: ar1107 Dialog: HAERDAJ

Global ID: 10054 PartySlot: 6

Script name:haerdalis Current action: -1

Int. Flags: 0x50a04 TalkCount: 2 Allegiance: 2 current allegiance:2

Class: 5 current class:5

Race: 153 current race:153

Gender: 1 current gender:1

Specifics: 0 current specifics:0

Alignment: 32 current alignment:32

Morale: 20 current morale:20

Moralebreak:5 Morale recovery:60

Visualrange:30 (Explorer: 1)

Levels:

BARD: 11

Summary: 11

current HP:48

Mod[iE_ANIMATION_ID]: 0x6001 ResRef:cemb1

TURNUNDEADLEVEL: 0 current: 0

Colors: 425943833 1111638594 1734829927 1414812756 1667063139 421206809 303174162

WaitCounter: 0

LastTarget: 0 <NULL>

LastTalked: 0 <NULL>

INVENTORY:

7: ring06 - (0 0 0) Fl:0x6c21 Wt: 0 x 0Lb

9: npsw06 - (1 0 0) Fl:0x6c21 Wt: 0 x 2Lb

10: fist - (1 0 0) Fl:0x2029 Wt: 0 x 0Lb

15: misc3m - (2 0 0) Fl:0x6c21 Wt: 0 x 6Lb

16: potn08 - (5 0 0) Fl:0x6ca1 Wt: 5 x 1Lb

21: potn14 - (1 0 0) Fl:0x6ca1 Wt: 5 x 1Lb

22: potn43 - (1 0 0) Fl:0x6ca1 Wt: 5 x 1Lb

35: npsw05 - (1 0 0) Fl:0x6c61 Wt: 0 x 2Lb

Equipped: 0

Total weight: 17

SPELLBOOK:

Known spells:

0: spwi106 L: 0 T: 1

1: spwi112 L: 0 T: 1

2: spwi113 L: 0 T: 1

3: spwi116 L: 0 T: 1

Memorized spells:

0: spwi106 1

1: spwi112 1

2: spwi113 1

Known spells:

0: spwi214 L: 1 T: 1

1: spwi201 L: 1 T: 1

2: spwi206 L: 1 T: 1

3: spwi209 L: 1 T: 1

4: spwi212 L: 1 T: 1

Memorized spells:

0: spwi201 1

1: spwi206 1

2: spwi209 1

Known spells:

0: spwi318 L: 2 T: 1

1: spwi317 L: 2 T: 1

2: spwi303 L: 2 T: 1

3: spwi305 L: 2 T: 1

4: spwi312 L: 2 T: 1

Memorized spells:

0: spwi303 1

1: spwi305 1

2: spwi312 1

Known spells:

0: spwi407 L: 3 T: 1

1: spwi408 L: 3 T: 1

2: spwi401 L: 3 T: 1

3: spwi406 L: 3 T: 1

Memorized spells:

0: spwi401 1

Known spells:

0: spwi515 L: 4 T: 1

Known spells:

0: spwi604 L: 5 T: 1

Known spells:

0: spcl522 L: 0 T: 2

1: spcl521 L: 0 T: 2

2: spcl522 L: 0 T: 2

3: spcl521 L: 0 T: 2

4: spcl522 L: 0 T: 2

5: spcl521 L: 0 T: 2

Memorized spells:

0: spcl521 1

1: spcl522 1

2: spcl521 1

3: spcl522 1

4: spcl521 1

5: spcl522 1

EFFECT QUEUE:

0: 0xe9: Proficiency (1, 96) S:

1: 0xe9: Proficiency (2, 91) S:

2: 0xe9: Proficiency (1, 106) S:

3: 0xe9: Proficiency (2, 114) S:

4: 0x36: ToHitModifier (1, 0) S:

5: 0x5c: PickPocketsModifier (-12, 0) S:cdblpp1

6: 0x5c: PickPocketsModifier (-3, 0) S:cdblpp3

7: 0x5c: PickPocketsModifier (-2, 0) S:cdblpp2

8: 0x5c: PickPocketsModifier (-3, 0) S:cdblpp3

9: 0x5c: PickPocketsModifier (-2, 0) S:cdblpp2

10: 0x5c: PickPocketsModifier (-3, 0) S:cdblpp3

11: 0x5c: PickPocketsModifier (-2, 0) S:cdblpp2

12: 0x5c: PickPocketsModifier (-3, 0) S:cdblpp3

13: 0x5c: PickPocketsModifier (-2, 0) S:cdblpp2

14: 0x5c: PickPocketsModifier (-3, 0) S:cdblpp3

15: 0x5c: PickPocketsModifier (-2, 0) S:cdblpp2

16: 0x00: ACVsDamageTypeModifier (1, 0) S:

17: 0x21: SaveVsDeathModifier (1, 0) S:

18: 0x22: SaveVsWandsModifier (1, 0) S:

19: 0x23: SaveVsPolyModifier (1, 0) S:

20: 0x24: SaveVsBreathModifier (1, 0) S:

21: 0x25: SaveVsSpellsModifier (1, 0) S:

22: 0x07: Color:SetPalette (27, 37) S:

23: 0x07: Color:SetPalette (93, 36) S:

24: 0x07: Color:SetPalette (99, 32) S:

25: 0x07: Color:SetPalette (27, 21) S:

26: 0x07: Color:SetPalette (93, 20) S:

27: 0x07: Color:SetPalette (99, 16) S:

 

 

 

Note : That already happened to me once with Minsc during/after the "Boo Kidnapping" quest from Unfinished Business when he is given (by spell) a Thac0 malus then later the reverse bonus. I've been able to fix this one by loading a save just before Boo disappeared and editing all spells related to this quest with Near Infinity (removing these malus/bonus).

This time, the only save I have is before recruiting Haer, but after meeting him at Mekrath's place so I don't know if removing his bonus from his .cre files will work. I should try this evening.

 

I use GemRB v0.7.1 (the git one gave me compiling errors (or was it just warnings?) last time I tried).

[lynx]

Interesting, it indeed has permanent timing. I guess we should remove it from the queue, since it has a cumulative effect.

 

... fixed.

[MouToN]

So if I want to continue my game with Haer, is there any way to remove this modifier from the effect queue? I've looked in /usr/local/share/doc/gemrb/en/, but I'm a little bit lost. Should I use DispelEffect() ?

[Avenger]

Is the problem caused by our wrong implementation of apply effect? (timing should be inherited from the caller)

 

Or, the fault is with the fixpack?

[lynx]

opcode problem, check the commit mails.

 

MouToN: just delete it with an editor, I'm not sure we expose a nice way for single arbitrary effect removal in the bindings. Enhance an item he's wearing to get the bonus back, but change the timing to While equipped.