SearchBitmaps not corrected (PST)

[aqrit]

With Widescreen mod, when Planescape: Torment crashes upon entering a small area

the exception is caused by some instruction reading beyond the end of a memory page right under a "CSearchBitmap.cpp" assert. ( VA 005894A3 with 4CDv1.1 )

 

I notice some bitmaps are not being updated to account for the newly added tiles...

 

for example the area when you exit through the portal in the mortuary:

AR0206HT.BMP

AR0206LM.BMP

AR0206SR.BMP

 

If I understand right, each pixel in these files represents a 16x12 px space in the area.

AR0206 has 13x14 tiles (before)

(( 13 * 64 ) + 15 ) / 16 = 52 px

(( 14 * 64 ) + 11 ) / 12 = 75 px

 

but has 25x17 tiles AFTER WSM (1440x900)

(( 25 * 64 ) + 15 ) / 16 = 100 px

(( 17 * 64 ) + 11 ) / 12 = 91 px

 

so the bmps should be 100x91 but are still 52x75.

 

this seems a likely cause for crashing...

 

 

I edited the AR206 bmps to the larger size and ran the level several times without crashing but that is anecdotal.

I'm soliciting for any relevant thoughts or info.

( such as what is the deal with xRatio in patch_bmp.tra )

[aqrit]

submitted patch as pull request

[aqrit]

Looking thru some commit history...

 

https://github.com/v...bfdb7e984dd1e88

Makes no sense.

It certainly is the cause of MUCH pain and suffering.

Is the reason why people are recommending rolling back to wsm 2.2 for playing PST

does anyone know the specific issue it was meant to address?

 

I've tested my patch on bg1 and everything looks okay at a casual glance...