SR V4 Beta 15

[subtledoctor]

That's because SR overwrites those spells with its own versions - which do not have the new EE 2.5 behavior.

It's not even SCS that has problems with those spells, it's the Detectable Spells function inside SCS. DS has been update in a few other mods, like RR... we just need someone (Wisp? Mike?) to put the updated version of DS into mods like SCS and SR.

The illegal 2-byte read thing is unrelated, it was due to a bug in Weidu 245, which has been fixed in Weidu 246.

Edited August 2, 2018 by subtledoctor

[AL|EN]

@subtledoctor If you point me to the file and add a quick info where I should put it, I can preform update via Fixpack.

[Aryn]

I am getting the following error while installing as part of EET on SoD 2.3 and BG2EE 2.5. I ran the Big World Fixpack prior to installing.

ERROR: Failure("SPIN920.SPL: read out of bounds")

I tried the fix suggested on Beamdog about exporting spells via NI and then placing into /override. I still got the same error.

 

Install order:

BGEE SoD
BGIIEE
BG1NPC
BG1NPC Music
BG1 NPCs
BG1 Unfinished Business *all

EET

Ascension
BGE Mini Quests and Encounters *all
Questpack
Sirene’s Call
Assassinations
Back to Brynnlaw

Amber
Angelo
Isra
Keto
de’Arnise Romance
Banter Pack
Crossmod Banter

Item Revisions
Spell Revisions

Unfinished Business
Alternatives
The Wheels of Prophecy
Thief Stronghold
Skip Chateau Irenicus
IWDification

Divine Remix
Song & Silence *all
Rogue Rebalancing
WSR
Refinements *shapeshifting fix

Tweaks Anthology
SCS
EET Tweaks
aTweaks 
UITweaks *permanent thieving button
NPCEE

[Aryn]

After testing with various mods in the mod install order the error appears to be related to ascension.

[DrAzTiK]

witch version of ascension do you use ?

[K4thos]

more info about this issue (btw. it's not related to EET) https://forums.beamdog.com/discussion/71686/error-failure-spin920-spl-read-out-of-bounds

Similar problem in SCS: https://forums.beamdog.com/discussion/comment/971562/#Comment_971562

 

edit: looks like the problem is already discussed in the previous page.

Edited July 24, 2018 by K4thos

[Aryn]

DrAzTiK -

 

Looks like Ascension v15 Beta.

K4thos -

 

I didn't think it was related to EET. I was just trying to give as much info about my install to narrow things down. I tried the fix in the Beamdog post, like I mentioned, but I will try again. I exported from a backup of a clean install. I'll try downloading a new version of BG2EE and export the spells to see if that works.

[CrevsDaak]

Re: crashes on non-EE games. Since I'm still playing BGT, I put together this small tool that enumerates and then removes every single opcode that might cause the game to crash from spells (I didn't bother making it do that on one run, so it does two, which is not efficient but it does it's job so who cares).

COPY_EXISTING_REGEXP GLOB ~^.+\.spl$~ override
  GET_OFFSET_ARRAY ab_array SPL_V10_HEADERS
  PHP_EACH ab_array AS int => ab_off BEGIN
    GET_OFFSET_ARRAY2 fx_array ab_off ITM_V10_HEAD_EFFECTS
    PHP_EACH fx_array AS int => fx_off BEGIN
      READ_SHORT fx_off fx_type
      PATCH_IF fx_type > 318 BEGIN
        PATCH_PRINT "%SOURCE_RES%.spl has invalid opcode %fx_type%"
      END
    END
  END
BUT_ONLY

COPY_EXISTING_REGEXP GLOB ~^.+\.spl$~ override
  LPF DELETE_SPELL_EFFECT
    INT_VAR opcode_to_delete = 328
  END
BUT_ONLY

The first part is just there to check if there's anything more that might make the game crash, the second one removes everything that actually does (at least in my install), so it can be left alone and this should still work, given your install is only using that opcode.

 

This is what someone was reporting about four pages ago. MGoI had an 328 on it and was insta-crashing every single time, leaving no more information that saying it was related to CGEffect.cpp or some shit, which made me quickly realise it had to be this. I'd encourage whoever is currently managing SR to at least include the last action on the code I'm posting here.

[Aryn]

I got it to work after a clean install and exporting the spells again using NI.

[Bartimaeus]

Thanks for the code, CrevsDaak - useful for quickly un-EE-izing your install.

Edited July 29, 2018 by Bartimaeus

[Jarno Mikkola]

Is it worth it using Spell revision currently?

Depends, if you don't like modified games, then no.

But if you do... then this one is an option. One of thousands.

[Bartimaeus]

I'm going to not trust anymore anything by Demiurgus given the premises, it's been 12 years and we still don't have a definitive version.

 

Hey, that's how the creative process works. Sometimes you get new ideas that replace old ideas - or after a certain amount of playtesting, you realize that your new ideas maybe weren't quite as good as the old ideas to begin with, and there was a reason things were that way before. And sometimes you get bored with how something works and want to change it up just for the sake of doing something new. And other times...you majorly change the design of something, but then forgot to update its description - or vice versa. These things happen.

Edited August 5, 2018 by Bartimaeus

[subtledoctor]

No reason for panic... v4b15 is extremely stable and works extremely well, even some of the more experimental ideas are working great.

 

Now, there have been some game updates while nobody has been maintaining the mod, and that's always going to mean a bit of trouble. But it hardly follows that "Demivrgvs can't be trusted."

[Luke]

No reason for panic... v4b15 is extremely stable and works extremely well, even some of the more experimental ideas are working great.

Do you think this mod is compatible with SoD?

 

EDIT: No, it's not compatible ------> enemies don't make use of the new spells (as expected.....)

Edited August 13, 2018 by Luke

[AL|EN]

There is one fix missing from BETA 15:

 

spell_rev\components\main_component.tpa, line 1282

ACTION_IF NOT GAME_IS ~eet~ BEGIN
  COPY ~spell_rev\spwi1##\spwi123.spl~     ~override~  // Find Familiar
    SAY NAME1 @439    SAY UNIDENTIFIED_DESC @440
END

Please include it so we can remove Fixpack patches