CamDawg Posted January 16, 2019 Posted January 16, 2019 This is a nifty little function; I have one minor gripe with it. For female NPCs who are dead it routes you to state 10, strref 73956, which was originally just for Yoshimo: "I cannot do as you ask, child of Bhaal. The one you seek is dead and thus forever beyond my reach. His thread no longer connects with yours." Just swap out 'His' for 'Their' and we have a safe endpoint for all NPCs. Quote
Jarno Mikkola Posted January 16, 2019 Posted January 16, 2019 58 minutes ago, CamDawg said: Just swap out 'His' for 'Their' and we have a safe endpoint for all NPCs. That's barbaric. Grammar man, grammar. Quote
K4thos Posted January 17, 2019 Posted January 17, 2019 (edited) 73956 string is actually already replaced with following line by default: Quote I cannot do as you ask, child of Bhaal. The one you seek is dead and thus forever beyond my reach. This thread no longer connects with yours. Not sure if the grammar is correct here, so just in case I will swap "this" with "their" in the next release. edit: I've just checked the code and it looks like I forgot to add STRING_SET for this line even though the changed text exists in TRA files for all languages. So yeah, you've found a bug Thanks for reporting. Edited January 17, 2019 by K4thos Quote
bob_veng Posted January 18, 2019 Posted January 18, 2019 Watch out, the grammar is not correct. 'That' should be used instead of 'this'. Some ambiguity remains (his and her, correspondingly, would certainly be better) but i think it's ok, and better than 'their'. Quote
DavidW Posted January 18, 2019 Posted January 18, 2019 “This”, “that” and “their” are all grammatically fine (I don’t like “that” stylistically but tastes vary.) “Their” has a long history as a valid singular pronoun in English - Shakespeare uses it. Quote
Grammarsalad Posted January 19, 2019 Posted January 19, 2019 (edited) 7 hours ago, DavidW said: “This”, “that” and “their” are all grammatically fine (I don’t like “that” stylistically but tastes vary.) “Their” has a long history as a valid singular pronoun in English - Shakespeare uses it. Agreed. The real problem would be if the text had to be uncertain about temporal sequence. The English language is obsessed with time: https://www.amazon.com/Through-Language-Glass-Different-Languages-ebook/dp/B00403MO0M Edited January 19, 2019 by Grammarsalad Had to make it all gremagical. Also, linky Quote
CamDawg Posted January 19, 2019 Author Posted January 19, 2019 Pfft, like you can trust someone named grammarsalad. Quote
Jarno Mikkola Posted January 19, 2019 Posted January 19, 2019 On 1/18/2019 at 6:51 PM, DavidW said: “Their” has a long history as a valid singular pronoun in English - Shakespeare uses it. Well, that's a bit ironic, and not in the lease with Shakespeare not being a single person/writer, but a compilation. Quote
Grammarsalad Posted January 20, 2019 Posted January 20, 2019 On 1/18/2019 at 9:46 PM, CamDawg said: Pfft, like you can trust someone named grammarsalad. Quote
Recommended Posts
Join the conversation
You are posting as a guest. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.