SR Fixes: stage I

[grodrigues]

For the time being, I am taking up maintenance of SR. I am proceeding in a piecemeal but systematic frashion, so the first stage is applying the fixes that can be implemented by simply patching the spells that SR copies into the game folder -- this is simply due to how SR is implemented. Once that is done I will proceed to the code itself (e.g. anything that involves petrification, slowing, dispel, etc.), which will involve refactoring and making Bartimeus' job of synching SRR as easy as possible.

The first PR is already uploaded. When I upload more PR's I will update the list below:

Arcane spells:

 

https://github.com/Gibberlings3/SpellRevisions/pull/41
https://github.com/Gibberlings3/SpellRevisions/pull/47
https://github.com/Gibberlings3/SpellRevisions/pull/49
https://github.com/Gibberlings3/SpellRevisions/pull/51
https://github.com/Gibberlings3/SpellRevisions/pull/53
https://github.com/Gibberlings3/SpellRevisions/pull/56
https://github.com/Gibberlings3/SpellRevisions/pull/58
https://github.com/Gibberlings3/SpellRevisions/pull/61
https://github.com/Gibberlings3/SpellRevisions/pull/63

 

Divine Spells:

 

https://github.com/Gibberlings3/SpellRevisions/pull/46
https://github.com/Gibberlings3/SpellRevisions/pull/48
https://github.com/Gibberlings3/SpellRevisions/pull/50
https://github.com/Gibberlings3/SpellRevisions/pull/52
https://github.com/Gibberlings3/SpellRevisions/pull/54
https://github.com/Gibberlings3/SpellRevisions/pull/57
https://github.com/Gibberlings3/SpellRevisions/pull/59

They are for the most part an off-shoot of my earlier PR's and my mod spell_rev_rev so they have already had some testing and discussion. I will leave the PR's to stew for a time; if anyone is interested, by all means take a look and if you have any observations comment there. Do note that things get a bit technical and entangled with IE details and WeiDU and that many fixes, while technically correct, have but a small impact on a normal gameplay.

Since most of the patched files are in the binary format and there is no good way to generate meaningful diffs, if people are really interested, I can even upload how these fixes are being generated -- it is just a WeiDU mod, with a few bells and whistles to partition the work in digestible chunks, correctly move files from place to place, generate some extra debugging info, etc. Any other fixes that you think should be made, holler in this thread. I stress the word "fixes"; let us leave tweaks, rebalancing, new functionality, etc. for later.

Once I am satisfied with this first stage (and whatever other PR's appear; at the moment of writing this up, subtledoctor already submitted four), I will do a public release. In the meantime, if you are feeling adventurous, you can always git clone or download the latest version for a test run.

There are a few fixes in which it is not clear how to proceed. For each such would-be fix I will open a new thread with an RFC. If no consensus emerges, or no one cares, I will simply make an executive decision. So if you are bothered by a petty dictator steering things with an iron fist, speak up and present an argument.

Edited September 1, 2021 by grodrigues
Updating PR list

[Bartimaeus]

Thanks, grodrigues - I'll be sure to make time to review them again as well.

[grodrigues]

All the spell fix PR's are up (and many have already been merged); I still have to open a couple of RFC and submit a few more PR's, then I will declare this first stage done, do some install testing and roll out the next public release.

[Bartimaeus]

Thanks for your hard work, . ...Kind of sucks you spent all of that time working on the insane patch version of your fixes and then had to turn around and do it all over again with the base resource files, but that's the way she goes, I suppose...

[grodrigues]

On 9/2/2021 at 3:39 AM, Bartimaeus said:

Kind of sucks you spent all of that time working on the insane patch version of your fixes and then had to turn around and do it all over again with the base resource files, but that's the way she goes, I suppose...

Actually it is not as bad as it looks, as all patching is done with WeiDU code, so most of the work was shifting things around and make another pass through spell to uncover any mistakes -- and sure enough, some were caught.