Bartimaeus Posted September 6, 2021 Share Posted September 6, 2021 (edited) 16 hours ago, grodrigues said: PR is up. Dire charmed not covered because I am not convinced it should be neutral, but we can always revisit it later on. Since implementation is tricky, more pairs of eyes on it would be nice. Charm Person: It works fine...with the exception of your DVHCHRM.spl still specifying hostile charm. Charm Person or Animal: Why is there a 324 opcode that allows Command to dispel Charm Person or Animal in SPPR204.spl? Additionally, you are currently copying over sppr204.eff as "sppr204" - i.e. no ".eff", so the spell does not currently function. DVACHRM.spl's charm opcode also still specifies hostile charm, and there are...other weirdities in the .spl with piles of duplicated opcodes, see here: The only opcode that should have a duplicate is the charm opcode (for animals vs. humanoids). Edited September 6, 2021 by Bartimaeus Quote Link to comment
grodrigues Posted September 6, 2021 Author Share Posted September 6, 2021 (edited) @BartimaeusThanks for reviewing. Fixed the lack of neutral charm and the missing ".eff" extension. The duplicated opcodes should be fixed as well (typo in the argument to CLONE_EFFECT). Any other comments, holler in the PR itself please. As far as the 324 opcode, that is most likely the doings of kreso_eestatSR.tpa. The PR itself does nothing in that regard. The idea is I presume, to block spell if target is under Chaotic Commands. Edited September 6, 2021 by grodrigues Duplicated opcodes issue; cleaning misunderstandings Quote Link to comment
Bartimaeus Posted September 6, 2021 Share Posted September 6, 2021 5 hours ago, grodrigues said: @BartimaeusAny other comments, holler in the PR itself please. Why? It's easier to follow discussion on here, especially since I actually get notifications when people reply, . Quote Link to comment
grodrigues Posted September 6, 2021 Author Share Posted September 6, 2021 2 hours ago, Bartimaeus said: Why? It's easier to follow discussion on here, especially since I actually get notifications when people reply, Just to put the discussion along the PR. But I can also just link it here, so no problem, do whatever's more convenient for you. Quote Link to comment
Bartimaeus Posted September 7, 2021 Share Posted September 7, 2021 8 hours ago, grodrigues said: Just to put the discussion along the PR. But I can also just link it here, so no problem, do whatever's more convenient for you. Everything looks good to me now, . Quote Link to comment
Recommended Posts
Join the conversation
You are posting as a guest. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.