Jump to content

RFC: Neutral Charm Spells


Recommended Posts

16 hours ago, grodrigues said:

PR is up. Dire charmed not covered because I am not convinced it should be neutral, but we can always revisit it later on. Since implementation is tricky, more pairs of eyes on it would be nice.

Charm Person: It works fine...with the exception of your DVHCHRM.spl still specifying hostile charm.

Charm Person or Animal: Why is there a 324 opcode that allows Command to dispel Charm Person or Animal in SPPR204.spl? Additionally, you are currently copying over sppr204.eff as "sppr204" - i.e. no ".eff", so the spell does not currently function. DVACHRM.spl's charm opcode also still specifies hostile charm, and there are...other weirdities in the .spl with piles of duplicated opcodes, see here:

firefox_NI49DqmEQl.png

The only opcode that should have a duplicate is the charm opcode (for animals vs. humanoids).

Edited by Bartimaeus
Link to comment

@BartimaeusThanks for reviewing. Fixed the lack of neutral charm and the missing ".eff" extension. The duplicated opcodes should be fixed as well (typo in the argument to CLONE_EFFECT). Any other comments, holler in the PR itself please.

As far as the 324 opcode, that is most likely the doings of kreso_eestatSR.tpa. The PR itself does nothing in that regard. The idea is I presume, to block spell if target is under Chaotic Commands.

Edited by grodrigues
Duplicated opcodes issue; cleaning misunderstandings
Link to comment
2 hours ago, Bartimaeus said:

Why? It's easier to follow discussion on here, especially since I actually get notifications when people reply,

Just to put the discussion along the PR. But I can also just link it here, so no problem, do whatever's more convenient for you.

Link to comment
Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...