Guest the_sextein Posted September 18, 2021 Share Posted September 18, 2021 I did a full install on BGEE and BG2EE V2.66 with EET and some other mods. Everything installed but some of them installed with warnings. "smarter Priests" "Improved Cloakwood Druids" "Improved Abizigal's lair" They all have parsing errors. I don't remember ever having them before even with my manually patched version 33.7 version of SCS. Here is an example of one of the many error's I see. [weidu_external/workspace/spellchoices_defensive/vanilla/druid.tph] ERROR at line 49 column 1-70 Near Text: BARKSKIN Parsing.Parse_error ERROR: parsing [weidu_external/workspace/spellchoices_defensive/vanilla/druid.tph]: Parsing.Parse_error Stopping installation because of error. Stopping installation because of error. Stopping installation because of error. Stopping installation because of error. ERROR: [izefia.CRE] -> [override/izefia.CRE] Patching Failed (COPY) (Parsing.Parse_error) Stopping installation because of error. Failed to patch izefia.CRE; error message was Parsing.Parse_error Failed to patch izefia.CRE; error message was Parsing.Parse_error Appending to files ... ...done Link to comment
Guest the_sextein Posted September 18, 2021 Share Posted September 18, 2021 The only component I didn't install was the Icewind Dale spells. All components installed without any errors outside of the 3 components previously listed. Link to comment
DavidW Posted September 18, 2021 Author Share Posted September 18, 2021 Interesting. Can you fish out the file 'weidu_external/workspace/spellchoices_defensive/vanilla/druid.tph' and post it here? Link to comment
Guest the_sextein Posted September 18, 2021 Share Posted September 18, 2021 I'm not seeing a way to upload files here so I'll just post it. DEFINE_PATCH_FUNCTION defensive_spells_druid INT_VAR level=0 fighter=0 RET spells BEGIN SPRINT spells ~~ INNER_ACTION BEGIN RANDOM_SEED 3.14 END PATCH_MATCH level WITH //////////////////////////////////// level 1 ////////////////////////////////////////// 1 BEGIN SPRINT "spells" "%spells% "^ BLESS END //////////////////////////////////// level 2 ////////////////////////////////////////// 2 BEGIN SPRINT "spells" "%spells% "^ ~BLESS~ END /////////////////////////////////////////// level 3 ///////////////////////////////////// 3 BEGIN SPRINT "spells" "%spells% "^ ~BLESS FLAME_BLADE~ END /////////////////////////////////////////// level 4 ///////////////////////////////////// 4 BEGIN SPRINT "spells" "%spells% "^ ~BLESS FLAME_BLADE ARMOR_OF_FAITH~ LPF internal_push_random STR_VAR list="%spells%" to_add="BARKSKIN null" RET spells=list END END /////////////////////////////////////////// level 5 ///////////////////////////////////// 5 BEGIN SPRINT "spells" "%spells% "^ ~BLESS ARMOR_OF_FAITH FLAME_BLADE BARKSKIN~ LPF internal_push_random STR_VAR list="%spells%" to_add="CURE_DISEASE null null" RET spells=list END END /////////////////////////////////////////// level 6 ///////////////////////////////////// 6 BEGIN SPRINT "spells" "%spells% "^ ~BLESS ARMOR_OF_FAITH FLAME_BLADE BARKSKIN~ LPF internal_push_random STR_VAR list="%spells%" to_add="CURE_DISEASE null" RET spells=list END END /////////////////////////////////////////// level 7 ///////////////////////////////////// 7 BEGIN SPRINT "spells" "%spells% "^ ~BLESS ARMOR_OF_FAITH FLAME_BLADE BARKSKIN~ LPF internal_push_random STR_VAR list="%spells%" to_add="CURE_DISEASE null" RET spells=list END LPF internal_push_random STR_VAR list="%spells%" to_add="DEFENSIVE_HARMONY null" RET spells=list END END /////////////////////////////////////////// level 8-9 ///////////////////////////////////// 8 BEGIN SPRINT "spells" "%spells% "^ ~BLESS ARMOR_OF_FAITH BARKSKIN FLAME_BLADE CURE_DISEASE DEFENSIVE_HARMONY END /////////////////////////////////////////// level 8-9 ///////////////////////////////////// 9 BEGIN SPRINT "spells" "%spells% "^ ~BLESS ARMOR_OF_FAITH BARKSKIN FLAME_BLADE CURE_DISEASE DEFENSIVE_HARMONY~ SPRINT "spells" "%spells% "^ IRONSKIN_PRECAST END /////////////////////////////////////////// level 10-11 ///////////////////////////////////// 10 11 BEGIN SPRINT "spells" "%spells% "^ ~BLESS ARMOR_OF_FAITH BARKSKIN FLAME_BLADE CURE_DISEASE DEFENSIVE_HARMONY~ PATCH_IF !fighter BEGIN LPF internal_push_random STR_VAR list="%spells%" to_add="CHAOTIC_COMMANDS null" RET spells=list END SPRINT "spells" "%spells% "^ IRONSKIN_PRECAST END END /////////////////////////////////////////// level 12 ///////////////////////////////////// 12 BEGIN SPRINT "spells" "%spells% "^ ~BLESS ARMOR_OF_FAITH BARKSKIN FLAME_BLADE CURE_DISEASE DEFENSIVE_HARMONY ZONE_OF_SWEET_AIR~ PATCH_IF !fighter BEGIN LPF internal_push_random STR_VAR list="%spells%" to_add="CHAOTIC_COMMANDS null" RET spells=list END END SPRINT "spells" "%spells% "^ IRONSKIN_PRECAST END /////////////////////////////////////////// level 13 ///////////////////////////////////// 13 BEGIN SPRINT "spells" "%spells% "^ ~BLESS ARMOR_OF_FAITH BARKSKIN FLAME_BLADE CURE_DISEASE DEFENSIVE_HARMONY ZONE_OF_SWEET_AIR~ PATCH_IF !fighter BEGIN LPF internal_push_random STR_VAR list="%spells%" to_add="CHAOTIC_COMMANDS null" RET spells=list END END LPF internal_push_random STR_VAR list="%spells%" to_add="PHYSICAL_MIRROR null" RET spells=list END SPRINT "spells" "%spells% "^ IRONSKIN_PRECAST END /////////////////////////////////////////// level 14-15 ///////////////////////////////////// 14 15 BEGIN SPRINT "spells" "%spells% "^ ~BLESS ARMOR_OF_FAITH BARKSKIN FLAME_BLADE CURE_DISEASE DEFENSIVE_HARMONY ZONE_OF_SWEET_AIR~ SPRINT "spells" "%spells% "^ ~CHAOTIC_COMMANDS IRONSKIN~ LPF internal_push_random STR_VAR list="%spells%" to_add="MAGIC_RESISTANCE null" RET spells=list END LPF internal_push_random STR_VAR list="%spells%" to_add="PHYSICAL_MIRROR null" RET spells=list END SPRINT "spells" "%spells% "^ IRONSKIN_PRECAST END /////////////////////////////////////////// level 16-17 ///////////////////////////////////// 16 17 BEGIN SPRINT "spells" "%spells% "^ ~BLESS ARMOR_OF_FAITH BARKSKIN FLAME_BLADE CURE_DISEASE DEFENSIVE_HARMONY ZONE_OF_SWEET_AIR~ SPRINT "spells" "%spells% "^ ~CHAOTIC_COMMANDS IRONSKIN~ LPF internal_push_random STR_VAR list="%spells%" to_add="PROTECTION_FROM_FIRE null" RET spells=list END LPF internal_push_random STR_VAR list="%spells%" to_add="MAGIC_RESISTANCE null" RET spells=list END LPF internal_push_random STR_VAR list="%spells%" to_add="PHYSICAL_MIRROR null" RET spells=list END SPRINT "spells" "%spells% "^ IRONSKIN_PRECAST END /////////////////////////////////////////// level 18+ ///////////////////////////////////// DEFAULT SPRINT "spells" "%spells% "^ ~BLESS ARMOR_OF_FAITH BARKSKIN FLAME_BLADE CURE_DISEASE DEFENSIVE_HARMONY ZONE_OF_SWEET_AIR~ SPRINT "spells" "%spells% "^ ~CHAOTIC_COMMANDS IRONSKIN REGENERATE MAGIC_RESISTANCE~ LPF internal_push_random STR_VAR list="%spells%" to_add="PROTECTION_FROM_FIRE null" RET spells=list END LPF internal_push_random STR_VAR list="%spells%" to_add="PHYSICAL_MIRROR null" RET spells=list END SPRINT "spells" "%spells% "^ IRONSKIN_PRECAST END /// end of main patch PATCH_IF (level>8 && fighter) BEGIN SPRINT "spells" "%spells% "^ RIGHTEOUS_MAGIC END END Link to comment
DavidW Posted September 18, 2021 Author Share Posted September 18, 2021 If you edit stratagems/priest/spellchoices_defensive/vanilla/druid.tph, and add a tilde (~) at the end of line 45, and then reinstall those components, I think they'll work fine. (It's a typo in my non-IWD druid defense code; I didn't make the same typo in the IWD version, so my install-everything check didn't catch it.) Link to comment
Guest the_sextein Posted September 18, 2021 Share Posted September 18, 2021 /////////////////////////////////////////// level 5 ///////////////////////////////////// 5 BEGIN SPRINT "spells" "%spells% "^ ~BLESS ARMOR_OF_FAITH FLAME_BLADE BARKSKIN~ LPF internal_push_random STR_VAR list="%spells%" to_add="CURE_DISEASE null null" RET spells=list END END It looks like null was accidently typed twice in a row. Don't know if that helps. Link to comment
Chitown Willie Posted September 18, 2021 Share Posted September 18, 2021 David, Thank you so much for all your hard work - Much appreciated. So far, just 1 Warning w/ BGT 1.21 + 34.1: INSTALLED WITH WARNINGS Initialise AI components (required for all tactical and AI components) Details: Copying and patching 1 file ... [./override/claird.cre] loaded, 1460 bytes override/claird.cre copied to weidu_external/backup/stratagems/5900/claird.cre, 1460 bytes Copied [claird.cre] to [override/claird.cre] Copying and patching 1 file ... [./override/sppr313.spl] loaded, 202 bytes WARNING: no effects altered on sppr313.spl I'll tackle "Smarter Mages" tomorrow. Link to comment
the_sextein Posted September 19, 2021 Share Posted September 19, 2021 (edited) Sorry it took so long to reply, the message board wouldn't let me post unless I signed up. I added the ~ on line 45 like you instructed and it fixed all of the problems. I installed all components other than the Icewind Dale spells with zero errors. That was a quick fix, good work. Edited September 19, 2021 by the_sextein Link to comment
tomasz86 Posted September 19, 2021 Share Posted September 19, 2021 (edited) 1 hour ago, Guest the_sextein said: /////////////////////////////////////////// level 5 ///////////////////////////////////// 5 BEGIN SPRINT "spells" "%spells% "^ ~BLESS ARMOR_OF_FAITH FLAME_BLADE BARKSKIN~ LPF internal_push_random STR_VAR list="%spells%" to_add="CURE_DISEASE null null" RET spells=list END END It looks like null was accidently typed twice in a row. Don't know if that helps. Not an expert, but the string "null null" is used like that in many other *.tph files, so I doubt this is an accident. I may be wrong though, so don't quote me on this. Edited September 19, 2021 by tomasz86 Link to comment
DavidW Posted September 19, 2021 Author Share Posted September 19, 2021 2 hours ago, Guest the_sextein said: /////////////////////////////////////////// level 5 ///////////////////////////////////// 5 BEGIN SPRINT "spells" "%spells% "^ ~BLESS ARMOR_OF_FAITH FLAME_BLADE BARKSKIN~ LPF internal_push_random STR_VAR list="%spells%" to_add="CURE_DISEASE null null" RET spells=list END END It looks like null was accidently typed twice in a row. Don't know if that helps. No, that's intentional. One spell is selected at random from the list, and 'null' translates to no spell. So that means there's a 1/3 chance of the creature having Cure Disease. Link to comment
Ryofu Posted September 19, 2021 Share Posted September 19, 2021 First i would like to thank all the people who updated and helped to bugfix this great mod. Can i ask if there are anymore updates and bugfixes planned in the short term? Should i wait abit first for abit before installing SCS or can i install in now? I am asking because everything i update i plan to delete everything, reinstall my EET and go through the process of installing my mods again before starting all over again ingame to ensure a bug free experience . Would really prefer to reduce the number of times i go to the Nashkel mines . Regards Link to comment
Cahir Posted September 19, 2021 Share Posted September 19, 2021 @DavidWdo you plan to drop 34.2 in case you've got the missing .tra files translated? Link to comment
Guest Bozerg Posted September 19, 2021 Share Posted September 19, 2021 Getting the following error when trying to install SCS 34.1, specifically "Include arcane spells from Icewind Dale: Enhanced Edition" and "Include divine spells from Icewind Dale: Enhanced Edition" ERROR: cannot convert ms2table or %ms2table% to an integer ERROR: [wand10.itm] -> [override/wand10.itm] Patching Failed (COPY) (Not_found) Link to comment
Salk Posted September 19, 2021 Share Posted September 19, 2021 (edited) A question, DavidW. If I modify some creature's original script(s) and/or swap the original script(s) with a new one(s) before installing SCS, what does SCS do when it comes to it? I'm asking because I customized a few combat scripts for some BG1 NPCs and was wondering if they'd be affected. Thanks. Edited September 19, 2021 by Salk Link to comment
Roberciiik Posted September 19, 2021 Share Posted September 19, 2021 (edited) Hello David, I looked at spellhold price change and I think changing price from 49999 to 4999 was incorrect. You changed "PartyGoldGT(49999) => PartyGoldGT(%asking_price_minus_one%)" into "PartyGoldGT(4999) => PartyGoldGT(%asking_price_minus_one%)". But there is already such replacement later: "PartyGoldGT(4999) => PartyGoldGT(%threshold_price_minus_one%)". I think that 49999 and 50000 prices were bugs from original game. Edited September 19, 2021 by Roberciiik Link to comment
Recommended Posts