Bernard sells unlimited prismatic spray scrolls

[TinyMage]

Bernard in the Copper Coronet seems to sell unlimited prismatic spray scrolls. I have pickpocketed over 30 so far. All the other scrolls seem to have a limit of 1 or 2.

[SConrad]

DLTCEP shows no error, and I checked it manually too. There's nothing wrong on my install.

 

Can you please check if either bernard5.sto, bernard6.sto or both is located in your override directory? If so, could you send them to me? sconrad@spellholdstudios.net

[Idobek]

Seb: bernard2.sto has unlimited Prismatic Spray scrolls for sale. bernard.sto and bernard2.sto are the files called from bernard.dlg.

[Rastor]

I'm honestly not sure that this is a bug.

[SConrad]

Seb: bernard2.sto has unlimited Prismatic Spray scrolls for sale. bernard.sto and bernard2.sto are the files called from bernard.dlg.

Oops.

 

It seems as if I've already fixed this locally some time ago and didn't see that bernard2.sto had that scroll for sale when looking through it today.

 

COPY_EXISTING ~bernard2.sto~ ~override~
READ_LONG 0x34 "itm_off"
READ_LONG 0x38 "itm_num"
WHILE ("%itm_num%" > 0) BEGIN
  SET "itm_num" = ("%itm_num%" - 1)
  READ_ASCII ("%itm_off%" + (0x1c * "%itm_num%")) "item"
  PATCH_IF ("%item%" STRING_COMPARE_CASE "scrl8p" = 0) BEGIN
    READ_BYTE  ("%itm_off%" + 0x10 + (0x1c * "%itm_num%")) "itm_flags"
    WRITE_BYTE ("%itm_off%" + 0xA  + (0x1c * "%itm_num%")) 1 // Set quantity/charges of item to 1
    WRITE_BYTE ("%itm_off%" + 0x10 + (0x1c * "%itm_num%")) ("%itm_flags%" BOR 0b00000001) // Set item flags to identified
    WRITE_BYTE ("%itm_off%" + 0x18 + (0x1c * "%itm_num%")) 0 // Set infinite flag to zero
  END
END
BUT_ONLY_IF_IT_CHANGES

...in any case. I should probably rewrite the code to use FOR-loops, but meh, this works too.

 

I'm honestly not sure that this is a bug.

I am. Why wouldn't it?

[CamDawg]

This, Gorch's Mace +2 (infinite), and shop07's large shield (infinite) have been added to Seb's monster store patch. Patch code for Gorch was there but we weren't copying the file.

[the bigg]

How about

 

ADD_STORE_ITEM + "SCRL8P" AFTER ~SCRL8L~ #1 #0 #0 ~IDENTIFIED~ #1 ?

 

the '+' means 'if the item is already present, replace the existing one, otherwise add a new item', and has been there since the dawn of time.

[CamDawg]

I blame Seb.

[devSin]

I offered my store fixes several times. They use ADD_STORE_ITEM, so each patch to an item in the store could be easily evaluated. Nobody cared.