Jump to content

khelban12

Members
  • Posts

    162
  • Joined

  • Last visited

Everything posted by khelban12

  1. I do not know gemrb's code like Lynx so i can't tell for sure but i don't think this has to do with your lag. The test i did with extspeed.2da had nothing to do with lag. gemrb uses the picture frame count as walking speed so some monsters (especially when infinity animations were used) were more fast or more slow than they should. I have a similar setup to yours (no sos, ctb, rot, planarsphere, npc mods, revisedbattles, kit mods, etc but i use all the major mods you use) and do not have your lag. I don't know if that makes a difference but my last mod is lolfixer that supposedly fixes many things. My setup is on linux and my gemrb version is commit 6f1b497a5a0bda41319a7baaa88a92d881393742 (2018-05-23) so a bit older than latest git.
  2. I wanted to suggest it for a long time but i didn't because it will put considerably more burden on Bartimaeus. It would be nice if you forked the original repo and then commit your changes describing the change so they can be pulled upstream by Demi or Mike. This way we won't have two separate projects.
  3. In case it makes any difference, i forgot to mention that i run gemrb from linux and install every mod using the linux weinstall (242 at this point). Yes, with the revised batch file applied, gemrb shows no warnings (at least in Irenicus's dungeon. i haven't managed to test any further areas). 408 files have different checksums (160 ITM, 191 CRE, 77 SPL). I checked them with iediff and the differences in item and spell files are all on parameter2 and resource (resource has bogus entries like h?@^E and stuff). For CRE files iediff says they are the same but if i hexdump them they have some differences where the new creature have a value of zero so i suppose it is the same fix but for effects inside creatures that iediff doesn't find because it checks only the cre header. Let me do a playthrough with it and check it more thoroughly if you want but it seems to work perfectly.
  4. I don't know if it is a bug but there is a minor inconvenience that i have for a long time and i keep forgetting to report. When i run the game through GemRB, i get tons of repeating "invalid opcode" errors. For example the following log is for the starting dungeon alone. Actor/ERROR: Invalid modifier type passed to NewStat: 106 (Aataqah)! Actor/ERROR: Invalid modifier type passed to NewStat: 106 (Cambion)! Actor/ERROR: Invalid modifier type passed to NewStat: 106 (Jailkeep Golem)! Actor/ERROR: Invalid modifier type passed to NewStat: 106 (Lesser Clay Golem)! Actor/ERROR: Invalid modifier type passed to NewStat: 24 (Imoen)! Actor/ERROR: Invalid modifier type passed to NewStat: 24 (Rielev)! Actor/ERROR: Invalid modifier type passed to NewStat: 24 (Sewage Golem)! I tracked it down to the core component of the Fixpack in lines 309-313 of file lib/bg2fp_effects_batches.tpa as you can see it here on github. // turns fear immunity into full immunity DEFINE_PATCH_MACRO ~cd_immunity_fear_arrays~ BEGIN DEFINE_ASSOCIATIVE_ARRAY cd_immunity_batches_key BEGIN // these three go last so they don't block their own extras effects 101, "-10", 23, "same", "-10", "-10", "last" => 1 // immunity to reset morale -> 101, "-10", 24, "same", "-10", "-10", "last" => 1 // immunity to horror -> 101, "-10", 106, "same", "-10", "-10", "last" => 1 // immunity to morale break modifier END DEFINE_ASSOCIATIVE_ARRAY cd_immunity_batches_extras BEGIN -> 23, "-10", "-10", "same", 1, 0, "first" => 1 // reset morale I don't know how the batch code works, but if i understood it correctly the "-10" means "i don't care about the value", right ? If yes, is it possible that subsequent lines use "stray" parameters from previous batch lines and so the 24 and 106 parameter from the previous lines end up in the Cure Horror (23) opcode ? As you see in the above picture, minhp1 has 106 as parameter2 which, while irrelevant for this opcode, gemrb sees it as an error. The same happens with imoenhp1 and 24 parameter. Probably with many other items too. If i change the second "-10" to 0 in the above line, then 0 is used as parameter2 and gemrb works correctly (but other batch line may have the same problem). Is this a fixpack bug or should gemrb change to ignore parameter values for opcodes that do not use them ? Thank you for your time.
  5. Greetings and congratulations to the team for the 0.8.5 release. There is a bug that i see for some time now but as always i forget to report a bug until i see a release announcement In the "Menkar Pebblecrusher" fight there is a thief NPC named Brennan Risling (sevpat05) who, if hurt sufficiently, leaves the area. So, in order for you to kill him, you have to hit him hard and kill him quickly before his script triggers. sevpat05.bcs contains the following code: IF HPPercentLT(Myself,50) Global("Hurt","LOCALS",0) See([PC]) THEN RESPONSE #100 Wait(2) StartDialogueNoSet([PC]) END sevpat05.dlg contains the following: Trigger: HPPercentLT(Myself,50) Global("Hurt","LOCALS",0) Action: SetGlobal("Hurt","LOCALS",1) EscapeArea() So, if he reaches less than 50% HP, he leaves. In the original engine, this works perfectly (though it seems to me that 50% is quite large and the party should never be able to kill him before the script triggers but maybe there is a delay). In GemRB, there is a weird behavior. The script triggers perfectly if you can't kill him quickly enough but it also triggers even when he is dead. 1) Steps to reproduce: * Create a character (preferably a hard-hitting character like a fighter, paladin, archer ranger, etc) * Escape Irenicus's Dungeon and in Waukeen's Promenade go to the upper floor of "Den of the Seven Vales" (AR0712 if you want to jump there) * Trigger the fight * Kill everyone else with ctrl+y and fight Brennan Observed result: Brennan dies and then his script triggers and he "escapearea"s so his loot is gone. Even killing him in one blow with the killsw01 or with ctrl+shift+y results in the script triggering. Can anyone else reproduce this or is it a bug in my installation ? 2) If there is a bug in my installation, of course disregard my post. If not, can this be fixed ? I found the HPPercentLT function in core/GameScript/Triggers.cpp. As always i blindly tried to find how to make it ignore dead people and found some code in another function. If i modify HPPercentLT as shown above, then it works and doesn't trigger for dead Brennan but something else weird happens. If i don't kill him fast enough, then the script triggers, he says the dialog but does not escape and you continue fighting him until you kill him. So this isn't the correct solution. Thank you for your time.
  6. I know it isn't exactly what you want, but in case you are not aware of it, this mod has a "Always win against Aesgareth" component.
  7. Tell me that again when you meat an enemy that's AC is 20 better against slashing weapons than blunt. And you are wrong. Or just regular golems that are immune to your regular slashing weapons ... well, they were. I thought 10 times to change that part and articulate it better because i knew someone would isolate it and take advantage that both the weapons i mentioned are blunt and so mention something like "skeletons" (or golems that you did) My point still stands though. Why would you form a warrior to have 4 attacks with clubs when you can have 4 attacks with two-handed swords (or long swords, etc) that will have more damage ? By modding we replace one imbalance we don't like with another (bigger or smaller) that we like.
  8. +1 I thought that this was exactly what the Speed Factor meant (and the same for casting speed for spells but this is irrelevant here). I may be wrong of course and the engine works differently but that was what i observed by using 1APR classes like thieves. Isn't this also why every thief guide suggests "speed weapons" so you can backstab early in the round ? It's just that because of >1 APR have to be squeezed in the 6 seconds, it pretty much becomes irrelevant for a character with many attacks. Edit: Yes, in PnP the Weapon Speed behave differently and is added to initiative. I was only talking about how it behaves in game. With regards to Jarno's post and that it will be ridiculous to go from 5APR to 1APR, yes this isn't a component that everyone will like. It will seriously nerf (to a point of being unusable) slow weapons and will favour quick weapons. In the vanilla game you have no reason (at least from a powergaming point of view) to use clubs, maces, etc when you can use long swords and two-handed swords. Or there are many people that use swords of small enchantment that have beneficial secondary effects instead of swords with larger enchantment. I read "balance" all the time in mod descriptions but in truth it is almost impossible to balance the game because "balancing" nerfs something and overpowers something else. With every component we install we exchange a certain imbalance that we don't like with a imbalance we like. All these of course, only if it was easily coded. I would then argue, as Fouinto said, that since it is optional then even if it is completely silly and useless, what is the problem ? Just don't install it. But since it is very difficult to implement then i agree that it isn't worth for CamDawg and other modders to devote an enormous amount of time just to humor me.
  9. One solution is to fork the github repository and then split your changes into distinct branches. For example, one branch for typos and corrections like the capitalization changes you have, one branch for 1pp removal, one branch for bug fixes in original IR items and descriptions, etc. This way, Demi and Mike can easily merge the branches they want and keep the controversial branches unmerged. It will be a large and tedious task though. If you decide to try this path, you can also use Lynx's excellent IE parser tools as git filters so git diff can show readable text differences between the binary item files which makes working with them a bit easier.
  10. Maybe it can be externalized in some 2da or in the lua ini file. I am not familiar with the EE engine at all. Would this pose a problem ? Whatever is the weapon's SF, that will be used. A mod that changes the SF for a weapon will have the description updated so the user will know it. Yeah this is a problem. Since equipping an offhand weapon gives an extra attack even to classes which are otherwise limited to 1APR (like thief), one way would be not to take the offhand in to account at all and limit only the "main hand APR". I agree. It would be a niche feature for crazy people like me
  11. I would like to suggest two component proposals (i already mentioned one of them in the other thread). Over the years, i have read them being mentioned on several fora so i guess they are not possible because the engine does not permit it(in ee maybe they are possible): 1) For "light" weapons like daggers, clubs, short swords, etc, use dexterity for THAC0 and Damage IF it would give a greater bonus than strength. 2) Limit the number of attacks based on the Weapon's Speed Factor. A combat round is split into 10 segments. When a weapon has a SF of 7, supposedly you need a time of 7/10 of a round in order to swing it because it is heavy. How is it possible to swing it 4 times in that time ? I would love to limit the APR based on the weapon's SF. That way, you need a weapon with a SF <= 5 in order to have 2 APR, a SF <= 3 to have 3APR, etc.
  12. What you describe in the 1st part is how BG2, BGEE, and BG2EE do indeed work. What you describe in the 2nd part is how IWD and IWDEE work. The "true" grandmastery component should rather be titled "true according to one guy who happened to make s mod and call it 'true.'" Thank you for answering. I didn't know about this discrepancy between BG2 and IWD. I, of course, do not know what steps the original modder took, but from what i read in IESDP, BG1 provides the version with the 1/2 attack more, so i guess it wasn't an error by the original modder. He just copied the BG1 version which was the de facto "correct" one. Maybe i was wrong wanting to change wspatck. Maybe wspatck is correct and it is the "GM table" that is shown here and there on fora and sites that is wrong ? Now, that we write about APR, there is a thing that i always wanted to be implemented in BG2 but i do not know if the engine doesn't permit it. Is it possible to limit APR based on the weapon's SF ? I find ridiculous that in a combat round which is split in 10 segments, you can get 4 APR with a two-handed sword that has a SF of 9 or something. I would love it if you needed a SF <=5 in order to get 2 APR, a SF <=3 to get 3 APR and so on.
  13. Sorry to hear that. Inspired by your post, i had coded my own version. It works for me but it is a very basic/stupid implementation with many quirks. It is not fit for general use but in case anyone is interested, it is the following:
  14. Obviously i have misunderstood something about this, but there is something that has bugged me for years. Maybe i have asked about it before and i do not remember. Isn't Grand Mastery supposed to give one full bonus attack from being proficient (or half an attack over specialization-high mastery) ? The original BG2 wspatck table has -1 for levels < 7, 1 for 7 <= level < 13, -2 for level >= 13. So we get half an attack bonus over being just proficient which is correct up until high mastery. If i haven't misunderstood, GM should give half an attack over that. So the "true GM" table should become 1, -2, 2 (So the character would get a total of 2, 2.5, 3 attacks respectively depending on his level) but instead the table installed by the mod has -2, 2, -3 and thus it gives half an attack more that it should give. What am i understanding wrongly ? Thank you.
  15. Seing Ardanis at the announcement topic reminded me of his Trap Detection mod. If i understood the situation correctly, it was going to be included in Demi's Kit Revisions mod but i think KR has stalled. If he is ok with it of course, wouldn't it be a nice tweak to have in the anthology ? The premise of the mod is that trap mechanics are crap in BG2. In other RPGs, thieves can always detect traps even when hidden (in some implementations they walk at half speed when detecting traps). In BG2, you can either walk hidden to scout ahead looking for enemies with the danger of triggering a trap, or detect traps and being seen by enemies. The only way to perform both is find traps while being invisible by a potion (or a cleric cast sanctuary on you).
  16. Greetings. I noticed that in my current playthrough i can rest in the "slaver stockade" building in the Slums whereas i think that i was not supposed to be able to rest there. I tracked it down to the "Disable non-hostile spawns" component that i have installed (i do not have its previous component "rest everywhere" installed of course) From what i understood, the file lib/rest_spawns.tpa has a code that enables bit7 for byte 0x48 that controls resting because component 3190 "rest everywhere" needs it but lacks a "if" clause to only set it when 3190 is installed ? I am sorry if i misunderstood the description and it works as it is supposed to. Also take notice that i haven't upgraded to v2 and still use v1 but from a quick diff with v2, the relevant code is the same so the behavior should be the same with v2 too. Thank you for your time.
  17. That's the one I use! But dwarves don't get 18 DEX. Are you sure about this ? The mod's Readme mentions "-Dwarves can now have 20 CON, but their CHR is limited to 16." Yes, both are quite strong and with practically no disadvantage. I guess he didn't have balance in his mind like you but wanted to implement 3.5 edition (If we read here, the standard 3.5 races of Hill Dwarves, High Elves, Lightfoot Halflings are exactly the same as his. Gnomes and Half-orcs are similar but not the same) Your version is more balanced. Losing 3 points may seem much from a power point of view as Jarno said but it seems logical (at least to me). Half-orcs are a bit bulky (hence +1 str -1 dex) and due to their orc half they would be a bit less intelligent (-1 int) and people would perceive them as ugly (-2 chr)
  18. Logical changes as always. For comparison, "Victor's Improved Races" component does the following changes: RACE STR DEX CON INT WIS CHA Human: 18 18 18 18 18 18 Elf: 18 20 16 18 18 18 Half-Elf: 18 19 17 18 18 18 Dwarf: 18 18 20 18 18 16 Halfling: 16 20 18 18 18 18 Gnome: 18 18 18 20 16 18 Half-orc: 20 17 20 15 18 17 It seems more or less inspired by 3.5 edition with some variations. I liked the fact that dwarves are viable thieves now but your version is more balanced and logical.
  19. SPAWNGRP.2DA Mods affecting SPAWNGRP.2DA: (None) The file uploaded by Roxanne is exactly the same as my bgt/backup/0/spawngrp.2da (so i guess vanilla bg2 one ?). BGT contains this include file that adds many entries to spawngrp.2da. Doesn't EET do a similar modification ? Edit: EET contains this code that does something with the file EET/temp/array/SPAWNGRP.2DA but i couldn't find a "temp" directory.
  20. Doesn't the suggestion Mike gave in an older thread about 1PP work ? I use that order myself and don't remember seing misalignment on helmets/shields and stuff. It probably is a stupid idea but if item_rev is changed not to copy any items (and only copy the relevant bams if 1pp is not already installed) but patch the items to create the necessary effects, would this problem with 1pp go away ?
  21. It's a insignificant nitpick but now that there is development, i thought i should ask about it. 38 39 40 41 ... 51 THIEF 6160000 6380000 6700000 6920000 ... -1 BARD 6160000 6380000 6700000 6920000 ... -1 The "Remove XP cap" component copies the file 2da/xplevel.2da which contains the above entries. After some levels, the XP needed for advancing as a Rogue stabilizes at 220K. So, shouldn't L40 (and every level after that) reduced by 100K to read 6600K instead of 6700K ?
  22. I would like to ask your opinion about the range of throwing weapons like darts and daggers. The "weapon changes" component changes their range from the default 20 to 15. git log says it was added a bit before Beta 6 (commit c2c189e644). Searching the forum, i found many posts talking about buffing darts, throwing daggers, etc by adding thac0, changing the dice to 1D4, etc but i couldn't find any discussion about the range (actually there was a thread from the V2->V3 era about the range but it was about lowering all weapons including bows/xbows). I understand that from a physics point of view, darts and daggers cannot fly as far as arrows / bolts but isn't 15 a bit small ? Every time my thief tried to use darts to attack someone, he got too close and was seen by the whole swarm of enemies that were near that one and everyone came after me. I had to resort to using a crossbow to attack once from distance and lure the enemy and then change to darts (but with 15 range i might as well change to dagger and backstab). Does anyone think throwing daggers/darts should have a larger range or they are fine and i just suck at tactics ? Thank you.
  23. Which version of ee are you running ? On BG2EE v1, 3.2064 linux version, i get the following hpclass.2da It indeed contains all the kits but if i understand correctly, they point to the same table as the base class. I may be wrong though. Ah, i looked the KR code and i get it now. It modifies RANGER to use HPRNG table but the kits are not modified and use HPWAR. You are right, please disregard my post.
  24. I guess i oversimplified the matter and didn't see all parameters. Almost all my playthroughs are solo (so i can't cast barkskin or other spells on top of the heavy armors) and my last playthroughs were as an Archer and Assassin with high dex, so i guess i judged the armors based on these characters and that is why i couldn't find any reason to justify the disadvantages of the heavier armors. I missed the bigger picture of the physical resistance and other benefits of the other armors. Thank you for your insight. I understand it now. I thought that since IR gives projectiles bonus damage based on their enchantment like BG1 did, maybe some gamers would dislike the extra +1 damage. Maybe this differentiation in arrows is better than what i suggested. I have faith in you choosing the best possible change as you did for other items. Yeah, +3 is perfect as i said before. I was just curious about it. Thank you for mentioning this. I follow your threads at the beamdog forum from the original scales of balance thread and agree with many of your changes. I haven't tried the mods yet though. Thank you all for your replies.
  25. Hello. I have some minor feedback about some items: a) Armor "Skin of the Forest +3" (item leat14. i think it replaces the "The Night's Gift" that you get from the umar hills mayor) has a base AC of 5 but grants Barkskin so it gives an AC of 1. Does anyone else think the -4AC benefit of barkskin is too much ? This is the same AC as "Mithral Chain Mail +4", "Bladesinger Chain +4", "Shadow Dragonhide +5" and others that require more trouble to be acquired. With the components that give heavier armors dexterity, movement, thieving penalties installed then the difference is even greater and it outclasses (at least from an AC point) a lot armors. For example, due to the dexterity penalties, a character with 18DEX has -3AC wearing it and also has -3AC wearing the "Deep Guardian's Plate" (base AC of -1) and has -4AC with "Enkidu's Plate" (base AC of -3) b) The enchantment level of Acid/Fire/Ice arrows are changed from vanilla 0 to 2/1/1 respectively. This is very nice but do you think it would be better if Fire/Ice arrows were also changed to +2 enchantment or they would be overpowered ? Last time i played an archer and found a Fire Elemental, i thought the most logical ammunition to use is an Ice Arrow but i couldn't hurt it because it was immune to weapons of less than 2 enchantment. Wouldn't it be logical to be able to use these Fire/Ice arrows on enemies of the opposite element ? c) Why are Arrows of Piercing changed to 3 enchantment and not 4 ? I do not have anything against this. It is a great change because it solves the problem with long bows and enchantment 3 is enough for pretty much any enemy. I just ask out of curiosity because the original description mentioned +4 to THAC0 so an enchantment of 4 would be the obvious choice. Thank you for your time.
×
×
  • Create New...