Offensive Spin / Boon of Lathander feedback string duplication

[aVENGER_(RR)]

A player recently reported that using Offensive Spin creates a double feedback message in his game (see screensot).

 

This occurs because the fixpack creates secondary spells from Offensive Spin and Boon of Lathander (by copying them) which also carries over the name of the original spell. This can be avoided by simply erasing the names of the secondary spells. Here's the fix (in diff form):

 

--- setup-bg2fixpack.tp2	2010-03-15 19:54:10.000000000 +0100
+++ setup-bg2fixpack.v10	2011-12-04 15:08:35.625000000 +0100
@@ -18813,6 +18813,7 @@
COPY_EXISTING ~spcl521.spl~  ~override/spcl521d.spl~
		   ~spcl741.spl~  ~override/spcl741d.spl~
  PATCH_IF (%SOURCE_SIZE% > 0x71) THEN BEGIN
+	SAY NAME1 #-1 SAY NAME2 #-1 // erase the name of the secondary spells to prevent feedback duplication
 WRITE_ASCIIT  0x10   ~~  // completion sound
 WRITE_SHORT   0x22  0x00 // casting graphics
 READ_LONG	 0x64  "ho"

 

Note: the new forum software seems to be messing up the code formating a bit.