SET_BG2_PROFICIENCY ~PROFICIENCYCLUB~ What’s wrong?

[Loremaster]

HI!

Learning to mod while trying to fix/tweak some NPC (Minsc, Keldorn, Mazzy, Korgan) weapon proficiencies. Stumble upon an installation error with the club proficiency. All weapon proficiencies work fine except club. The DEBUG file says: ”ERROR: cannot convert PROFICIENCYCLUB or %PROFICIENCYCLUB% to an integer”.

 

Classic BG2 ToB, pached 26498 English

WeiDu 249, ToBEx, BG2 Fixpack, Widescreen

Windows 10

 

My tp2 file looks like this.

BACKUP ~weidu_external/NNnpc1/backup~
AUTHOR ~Loremaster~
VERSION ~0.0.0.1~
AUTO_EVAL_STRINGS
//README ~NNnpc1/NNnpc1-readme.txt~

/*
LANGUAGE
    ~English~
    ~english~
    ~NNnpc1/languages/english/setup.tra~
*/

///////////////////////////////////////////////////////////
///////////////////////////////////////////////////////////
//                                                       //
//    Tweak/Fix Minsc's Weapon Proficiencies             //
//                                                       //
///////////////////////////////////////////////////////////


BEGIN ~Tweak/Fix Minsc's Weapon Proficiencies~ DESIGNATED 100

COPY_EXISTING
    ~minsc7.cre~ override
        SET_BG2_PROFICIENCY ~PROFICIENCYBASTARDSWORD~ 2
        SET_BG2_PROFICIENCY ~PROFICIENCYLONGSWORD~ 2
        SET_BG2_PROFICIENCY ~PROFICIENCYSHORTSWORD~ 2
        SET_BG2_PROFICIENCY ~PROFICIENCYAXE~ 2
        SET_BG2_PROFICIENCY ~PROFICIENCYTWOHANDEDSWORD~ 2
        SET_BG2_PROFICIENCY ~PROFICIENCYKATANA~ 2
        SET_BG2_PROFICIENCY ~PROFICIENCYSCIMITARWAKISASHININJATO~ 2
        SET_BG2_PROFICIENCY ~PROFICIENCYDAGGER~ 2
        SET_BG2_PROFICIENCY ~PROFICIENCYWARHAMMER~ 2
        SET_BG2_PROFICIENCY ~PROFICIENCYCLUB~ 2
        SET_BG2_PROFICIENCY ~PROFICIENCYSPEAR~ 2
        SET_BG2_PROFICIENCY ~PROFICIENCYHALBERD~ 2
        SET_BG2_PROFICIENCY ~PROFICIENCYFLAILMORNINGSTAR~ 2
        SET_BG2_PROFICIENCY ~PROFICIENCYMACE~ 2
        SET_BG2_PROFICIENCY ~PROFICIENCYQUARTERSTAFF~ 2
        SET_BG2_PROFICIENCY ~PROFICIENCYCROSSBOW~ 2
        SET_BG2_PROFICIENCY ~PROFICIENCYLONGBOW~ 2
        SET_BG2_PROFICIENCY ~PROFICIENCYSHORTBOW~ 2
        SET_BG2_PROFICIENCY ~PROFICIENCYDART~ 2
        SET_BG2_PROFICIENCY ~PROFICIENCYSLING~ 2
        SET_BG2_PROFICIENCY ~PROFICIENCY2HANDED~ 2
        SET_BG2_PROFICIENCY ~PROFICIENCYSWORDANDSHIELD~ 2
        SET_BG2_PROFICIENCY ~PROFICIENCYSINGLEWEAPON~ 2
        SET_BG2_PROFICIENCY ~PROFICIENCY2WEAPON~ 2

When I let WeiDu skip     SET_BG2_PROFICIENCY ~PROFICIENCYCLUB~ 2     by inserting "//" in front of the line, it works fine. (It doesn't matter if I put the club prof at the end (following engine numbering), same error occurs anyway.)

 

Thus, the above code works not, while the below works fine.

        SET_BG2_PROFICIENCY ~PROFICIENCYWARHAMMER~ 2
      //SET_BG2_PROFICIENCY ~PROFICIENCYCLUB~ 2
        SET_BG2_PROFICIENCY ~PROFICIENCYSPEAR~ 2

Is there something wrong with    SET_BG2_PROFICIENCY ~PROFICIENCYCLUB~

The DEBUG file is attached to this post.

 

/Loremaster

 

SETUP-NNNPC1.DEBUG

[subtledoctor]

I believe in some games it is “PROFICIENCYCLUB” and in some games it is “EXTRAPROFICIENCY1.” And may differ between patch versions as well. You should be able to see which it is in your game by looking at… STATS.IDS? I think?

But also, you can probably just use “115” and it should work everywhere. 

Edited October 12, 2023 by subtledoctor

[Loremaster]

I have solved it!!!

Thank you! @Subtledoctor You put me on the right track.

This are the last rows of the tp.2       

        SET_BG2_PROFICIENCY ~PROFICIENCYSINGLEWEAPON~ 2

        SET_BG2_PROFICIENCY ~PROFICIENCY2WEAPON~ 2

      //SET_BG2_PROFICIENCY ~PROFICIENCYCLUB~ 2  // Probably an oversight by the original developers. See WEAPROF.2DA and STATS.IDS in Near Infinity.

        SET_BG2_PROFICIENCY ~EXTRAPROFICIENCY1~ 2  //CLUB

 

By the way, Minsc will not have two points in all weapons when I am done. As a ranger of lvl seven, he has to settle with six original points plus two in 2-weapon for being a ranger.

 

/Loremaster

[jmerry]

Yeah, EE has this one fixed. You can check STATS.IDS to see what your version of the game has; clubs are the row after PROFICIENCY2WEAPON.

If you want this to be compatible with multiple versions of the game, you'll either need an IF branch or to just use the number. Because EXTRAPROFICIENCY1 is not defined in the EE.