[v35.15] Issues with BGT German test install

[MikeX]

I don't know, how helpful this will be, but here it is:

spell.tra:
-artifacts removed

General:
-Strings from shared.tra are installed in English although German is selected (e.g. *quaffs elixir of health*)

friendly_fiends_core.tpa, line 137:

        LAF return_detectable_string STR_VAR type="DW_POWER_UPGRADE_M1" RET string_low=string END
missing "

carsa_add.baf, line 64:

        DisplayStringHead(Myself,%carsa_say_strref_8%)
missing strref?

SPWI101.spl:

Text "3 Phasen" / "3 turns" added to the end of the spell description

 

 

 

Edited 7 hours ago by MikeX
Tested and updated with v35.15

[MikeX]

Tested again with offical release v35.11, first post updated

[MikeX]

On 4/23/2024 at 8:28 PM, MikeX said:

General:
-Strings from shared.tra are installed in English although German is selected (e.g. *quaffs elixir of health*)

I don't know how much help it is, but only for a test, I added this (tra=shared):

BEGIN @61 DESIGNATED 6000 GROUP @6
REQUIRE_PREDICATE MOD_IS_INSTALLED "setup-stratagems.tp2" 5900 || IS_AN_INT stratagems_component_5900_installed @16025
REQUIRE_PREDICATE !GAME_IS iwdee @50009

LAF run STR_VAR files=genai location=genai tra=shared END

As expected, it fails when the only line from genai.tra, @217, is called, but installs the lines from shared.tra according to the selected language.
Is there somewhere a with_tra block missing?

 

 

[DavidW]

I can't reproduce this. When I install the potion component of SCS (minimal install, just AI initialization, improved general AI, potions for NPCs) and pick German as my language, the strings all seem to be in German.

[MikeX]

Sorry, i might not be clear enough.

I've just installed AI initialization and improved general AI (component 6000).
I think, 6000 creates all the npc scripts and many of them have 'DisplayStringHead' lines and these lines referencing an English strings from shared.tra on my German install.

Example from d1melas.bcs.

        DisplayStringHead(Myself,133241)  // *quaffs potion of magic protection*

[DavidW]

You were perfectly clear; I just can't reproduce it. (You're right that the potion component isn't required, it's just the improved general AI.) On my install I have this line in dw1melas.bcs:

		DisplayStringHead(Myself,71888)  // Schluckt einen Magiewiderstandstrank

I guess it's possible it's something specific to BGT? (This is on a BGEE test run.) I'll have a look.

[DavidW]

I can reproduce this on BGT. Will investigate.

[DavidW]

Got it. You can hotfix by dropping the attached file into stratagems/sfo2e

charset_wrapper.tph

[MikeX]

Thank you, it works now.

[DavidW]

This is now included in v35.14.

[MikeX]

On 4/23/2024 at 8:28 PM, MikeX said:

SPWI101.spl:

Text "3 Phasen" / "3 turns" added to the end of the spell description

web_and_the_large.tpa, line 17:

        new:=@221

@22 -> @221

[MikeX]

Some component (Smarter Priests?) adds the unused string 'minimum_healing_level' to dialog.tlk.
Not an issue per se but maybe a hint that something is off elsewhere?

[DavidW]

The web_and_the_large issue is fixed. I can't quite work out what's going on with minimum_healing_level (and a couple of similar strings) but I *think* it's harmless.

[MikeX]

Thank you.

On 4/24/2024 at 2:28 AM, MikeX said:

carsa_add.baf, line 64:

        DisplayStringHead(Myself,%carsa_say_strref_8%)

Is there anything particular you had in mind for this, or is it just a missing string/strref?

[DavidW]

It's a typo (fixed locally) - it should be %carsa_say_8%. (that string is filled in by the code with the correct strref.)