Mad Mate

Are you saying that code from RevisedSCS branch can be installed regardless SR installed or not?

RevisedSCS is highly dependant to SR. It was made by Kreso because SCS was not reflecting SR changes. Kreso and everybody else thought it was because of ssl, but fact was SCS never detected SR properly.

Kreso found bug that Refinements was not detected, but didn't know SR and IR was also not detected. So he went changing ssl files so they reflect SR.

Bug was simple install order bug and now it is fixed.

 

SCS v31 RC3 is not SR dependent. It will detect SR and make scripts according on what you have.

 

As Jarno said, current v31RC3 is not official SCS version, I would call it "community" bugfixed SCS v30.

I highly doubt that DavidW will do this. He recently wrote that lot of SR design choices are not as want. Besides it's a lot of work and only the person who knows SR inside-out should do this.

Well, I hope he does. He even asked which one should he be using.

I like his vision regarding SCS, and hope he doesn't mind our bug fixing.

Anyway, if he doesn't, like I already said, you can always write your own custom library in ssl folder. Maybe kreso (or some other expert player/modder) come back and write one down. There is great potential there.

Yes, unless the RevisedSCS changes will be introduced to SCS and applied only when SR will be detected.

 

Difference between SCS RC3 and RevisedSCS now are only in ssl files (files that make up scripts).

Main SCS v30 had a bug that it wasn't detecting SR at all, and Kreso did a great job to change those ssl files to behave like you have SR installed.

I like some of his changes and use them in my personal build, but I think that it was not a proper way to change SCS behavior.

Proper way should be via custom library files in ssl (those didn't work also in v30, but now it is also fixed). Kreso tried that back then, but as it didn't work, he used "direct editing of ssl" solution.

Now, all that bugs are fixed and SCS v31RC3 detects SR properly and uses SR dependant parts of ssl scripts.

So SCS v31RC3 is not only for "without SR".

 

Only thing, now, that SCS RC3 doesn't do is using new SR4 changes, because it was made for SR3.

I hope DavidW will manage that in new release.

I recommended BWS mostly because you use very outdated Ascension v1.5 BETA_20160601. Grab last one here: https://github.com/BigWorldProject/Ascension/archive/master.zip

And I don't know is it recommended to use BG2Fixpack's components on BG2EE. Also some of the mods have different versions specifically for EE.

In short, BWS will help you to avoid problems other players already had and fixed.

It looks like some of the mods you installed broke SCS.
I suggest using BWS for downloading latest versions of mods, and installing mods in correct order with fixes for each mod (BiG-World-Fixpack).

Sorry, I'm new to this. I created new PR.

Is now better?

I see that fix made it to RC3 anyway.

Fix merged, thanks Mad Mate!

Thank you Alien, for all work you have done.

 

Just one request, can BWS automatically update ds.tph in mods that are using it?

In my test setup, 2 post up, clean BG2EE+BiGWorldProject-Ascension-20170708+SCSv31RC2, one spell got corrupted, SPIN920.SPL.

At first, I thought that it was SCS fault again, but after uninstalling component by component, culprit turn out to be Ascension, precisely DS part of it.

It still uses old DS.

I have been trying to install SCSv31 with EE Mod Tool for the last couple days and I keep having the same very specific error:

This is fixed. Get latest master ( https://github.com/Gibberlings3/SwordCoastStratagems/archive/master.zip ) until CamDawg release new RC version.

Errors:

Fixed: https://github.com/Gibberlings3/SwordCoastStratagems/pull/4

 

It happened because when I fixed Spell & Item Revision detection, now SCS actually reads what is in library files in ssl folder.

And typo was in library_notir.slb, which my game never use (I always install IR).

 

Note for other modders and players:

 

Look in ssl folder of SCS, there are libraries which SCS uses to make scripts for enemies. Most of them was never used because of wrong install order which is now fixed.

You can now even make custom main library and put name of library in ini file.

 

Example of usage is in library_ir.slb:

TRIGGER=SINecromancy
!HasItemEquiped("plat16",scstarget)

This code will be added to enemy scripts if you have IR installed. This means that if enemy mage spots that you have this armor, he won't use Finger of death on you and switch to different tactics. Bartimaeus

 

From the BD forums:

Did install of latest BG2EE and SCS (log attached) and everything went without problem, even Smarter beholders.

WeiDU.rar

"Improved Abazigal" was my fault and latest pull, that was merged, included fix.

But "Smarter Beholders" has nothing with other components. They don't depend on each other. Most likely install stopped at Beholders after first error and didn't continue.

Debug from install would be nice or just part that indicate error...

I don't have EE's installed so I can't test it.

 

Something I just remembered to mention now is when cloning spells as different filenames, instances of immunity spell opcodes (318/324) need to be updated so that they self-block the effects of the new spell rather than the original copied spell. SCS liberally clones spells, so I would integrate this change into the clone spells macros or whatever they are called.

That would be great if someone can write code. All about cloning spells is in sfo\filetype\lib_spl.tpa

It starts with:

 

 

If anyone's still interested, the thing with DS and EE 2.5 was that the DS code would add and delete effects in the same loop, but would not necessarily do so in the correct order, so which would produce incorrect results for some inputs (for example, it deletes an effect located last; delta is -1, then adds an effect at position 0, i.e., at fx_off + delta * fx_size, or 0x30 bytes before fx_off). EE 2.5 contains or contained files that would trigger this oversight. I posted a simple fix here and in the DS thread at SHS, but apparently I toil in obscurity.

 

Thank you, Wisp!

 

In latest DS (3.95), current one, in SCS it is:

SPRINT sort_array auxil
LPM sort_array

instead (like in your fix):

SORT_ARRAY_INDICES auxil NUMERICALLY

Should we change it?

All 3 functions are defined in caster_shared\caster_shared.tph

Yes, it is.

SCS always fail when it encounter corrupted item or spell file.

Find out what mod, installed before SCS, corrupted that file.

Attach your weidu.log &/or SCS debug, so anybody can help you.

Probably some new mod or recent version...

DVPLANGA.ITM, Mage Robe is installed in game, but it is not on PLANGOOD.CRE.

It could be intended, but weapon & ring (DVPLANGW & DVPLANGR) are already on it.

The DRAGBLUE.BCS I have doesn't contain any references to Tamah's creature file. From my amateur snooping, it doesn't look like the IsAscension variable is set when dragblue.ssl is compiled.

You're right again. IsAscension variable is missing.

To fix this (I tested this all afternoon), add in ascension\abazigal_dragon.tpa (line 3, before // compile scripts):

// detect Ascension Tougher Abazigal

ACTION_IF FILE_EXISTS_IN_GAME ~abazdg02.cre~ BEGIN
OUTER_SPRINT ~sslvariables~ ~%sslvariables%~^~&IsAscension=True~
END

Only other file that needs "IsAscension variable" is melissan\melissan.tpa, so add same line as above at same place.

Dragon form Abazigal is not getting the SCS version of his script with Ascension and Smarter Abazigal. The only script attached to to DRAGBLUE.CRE is the class script ABAZDRAG.BCS, which is obviously not an SCS script. For one thing, it's way too short. DRAGBLUE.BCS, which obviously IS an SCS script, is in my override folder but it isn't used by anything.

I think you are right. And you found-out why Tamah doesn't appear if Asc-based components of SCS is installed. Re-spawn block for Tamah is only in DRAGBLUE.BCS.

To fix this, I think it is enough to add in ascension\abazigal_dragon.tpa (somewhere in MAKE_PATCH (~line 20)):

swap_script=>~abazdrag=>dragblue~

Or you could do, like it is done in mage\mage_shared.tph:

replace in priest\priest_shared.tph (line 412):

SET av_5=av_5+1
SET av_6=av_6+1

with

PATCH_IF level>22 BEGIN
SET av_5=av_5+1
END
PATCH_IF level>23 BEGIN
SET av_6=av_6+1
END

I tested this and no extra spells for low level priests.

Only thing I'm not sure is what levels are intended for extra spells (22,23 like here or...)

Please do. I've re-installed to see if it's a BGT thing, and now I don't have the bug in my BGT install. I don't get it.

 

Slapri.cre has two level 5 spells, Mass cure both. No 6th or 7th level spells.

And I found out what is happening, but I don't know is it a bug or feature.

It only happen, when you have Refinements & SCS #6024 // Add high-level abilities (HLAs) to All component installed.

"Problem" is in priest\priest_shared.tph:

In line 347:

PATCH_IF ~refinements~=1 BEGIN
SET ~num_hla_innate~=level - 22 // enlightenment (benefit is extra spell levels, handled below)
SET enlightened=1

and later at 411:

PATCH_IF VARIABLE_IS_SET ~enlightened~ BEGIN
SET av_5=av_5+1
SET av_6=av_6+1
END

If you decomment second part, you get normal spell levels. I don't know why DavidW did this or there is some typo or bug here.

Maybe, somebody more experienced at code (CrevsDaak?) could look at this.

 

EDIT: I think extra spells should get priests higher of 22nd level, but here even lower ones gets them. Something here don't work right.

 

Not on current install. I don't even have Spell Rev now and the bug is there. (fwiw, my first guess was Refinements - SCS uses a specific cleric HLA which gives them extra 6th and 7th slots, so I tought this was working wrongly so it gives this ability to cleric of any level in BG2. It isn't. )

As I said, I can only get in in BGT install. BG2 alone is fine.

Hm, I'll try to reproduce this, if you give weidu.log of your BGT install. I can do install tonight.

 

I confirm it. I got Unholy Word & Heal. Will try to debug tomorrow.

Not on current install. I don't even have Spell Rev now and the bug is there. (fwiw, my first guess was Refinements - SCS uses a specific cleric HLA which gives them extra 6th and 7th slots, so I tought this was working wrongly so it gives this ability to cleric of any level in BG2. It isn't. )

As I said, I can only get in in BGT install. BG2 alone is fine.

Hm, I'll try to reproduce this, if you give weidu.log of your BGT install. I can do install tonight.

Bleh. I've got the same bug again. At least they have Unholy Word now.

I cannot reproduce the bug on a BG2-only install, regardless of my mod selection. I've tried with Questpack, w/o Questpack, Refinements, w/o Refinements, on a BG2 only install it works fine.

If I use BGT, they get level 6 & 7 spells. Change-log shows nothing new - same as above, only Stratagems. I'm lost here.

Kreso, I'm intrigued by this. I did another install and spell-books are still fine.

I guess that SCS, in your case, reads wrongly priest\spellchoices\demivrgvs\cleric_evil.2da table.

Did you change anything in it?

Abazigal's lair has the 4 drakes from Ascension as expected, but when Abazigal turns into a dragon Tamah does not spawn. Looking around with NearInfinity shows that Tamah's .CRE file is in the override folder but nothing references it.

This is intended, if you installed Smarter Abazigal. Why, don't ask me.

 

From ascension\abazigal.tpa:

// delay Tamah

LAF get_area_script STR_VAR area=ar6005 RET script=script END
LAF swap_text STR_VAR files= ~%script%.bcs~ swaps=~CreateCreature("ABAZDG02",\[1224.1287\],0)=>NULL~ END

Kreso, can you do a change-log of slapri.cre & rethug03.cre, so we can find what components added high-level spells?

Thanks!

I know. The problem is that even low-level clerics (see rethug03. level) get some really high-powered stuff. If they get FoD or not is random - I've checked him now, indeed he doesn't have FoD this time. He does have Aerial Servant (6th) and Unholy Word (7th) instead. His script is 2ECL3 - he should I guess get level 3 spells MAX.

Also, the priest in Slaver's boat will have same issues (just see their list of memorized spells). I can't vouch for others (there aren't many clerics of low-level in BG2) but these two surely aren't level 14.

Sure, there is something wrong. My Rethug03.cre also has 2ECL3 script, 6th level cleric and these spells:

 

and priest on Slaver's boat (SLAPRI.CRE), 10th level cleric, 2ECL5 script and these spells:

So, no spells higher of 5th level. Did you change anything in ini file? It could be some SCS component that I don't use.

My weidu.log (SCS part):

 

 

 

Change-log on these 2 CRE files would be helpful to find which component added these high level spells.

It's still there. Just check Stalman's script, you'll see the "warning" sign.

As per priests, the cleric in Suna ambush casts it, as do random Hobgoblin shamans.

I checked Stalman script, and in my install it is correctly compiled. I'll put his script in attach so you can check it.

And I found out about Suna ambush priest. It is RETHUG03.CRE, but creature (in my install) don't have FoD memorized, so it shouldn't fire.

In his script there are these multiple blocks with FoD, but they require creature have FoD among his spells:

 

 

 

Stalman.rar

 

RETHUG03.rar

kreso, that was bug in v29, corrected in v30.

Can you tell me which priest uses FoD? I can't find any priest, lower of level 12, that uses it, in my install.