[v35.3] SFO2E library bugs

[Angel]

lib_struct

Function struct_get fails to fetch fields of type 'flag', such as the can_buy or can_buy_cures flags of a store.  Suggested fix:

--- a/mih_fr/third_party/sfo2e/lib_struct.tph
+++ b/mih_fr/third_party/sfo2e/lib_struct.tph
@@ -3583,6 +3583,11 @@ BEGIN
                strref BEGIN
                        READ_STRREF offset value
                END
+               flag BEGIN
+                       n=$"SFO_%strtype%_flags"("%arguments%")
+                       READ_BYTE offset byte
+                       value = (byte BAND (2**n)) >> n
+               END
                DEFAULT
                        PATCH_WARN "unrecognized type %type% in struct_get"
                END

 

[DavidW]

I think there are quite a few things struct_get doesn't recognize, but I've added that one.

[Angel]

lib_bam:

The function to recenter bam frames went missing between SFO and SFO2E.  I'd write my own, but I'm uncertain about BAM v2 trickery for EE.

I used this one to restore misc9k (Third Journal of Irenicus) in BG2, which has a way off center description image.  Not a biggy as I can do the fix in a different way, but it would be a nice to have, please?

[Angel]

On 1/2/2024 at 6:09 PM, DavidW said:

I think there are quite a few things struct_get doesn't recognize, but I've added that one.

I realized that when I was comparing code for struct_get and struct_read, but this was a particular case that I needed.  I wanted to find stores that sell cures.   Thanks!