Remove Paralysis not removing stun icon

[TinyMage]

The priest spell remove paralysis does not remove the icon for stun, even though it frees the target from the effects of stun.

[CamDawg]

sppr308 has an effect to remove icons 55 (stun) and 13 (held). What caused the stun effect? It may be the stunning spell/item setting the wrong icon.

[devSin]

I couldn't ever confirm that any effect sets an icon that can't be cleared by the spell. In the absence of further info, this can probably be moved to no action.

[devSin]

Actually, one of these spells (I think it was this one, but maybe remove curse or something) has the remove icon effects, but they're target self.

 

Years of polishing BG2, and I didn't find this shit until last week.

[CamDawg]

// remove paralysis not removing icons on target
COPY_EXISTING ~sppr308.spl~ ~override~
 READ_LONG  0x64 "abil_off"
 READ_SHORT 0x68 "abil_num"
 READ_LONG  0x6a "fx_off"
 FOR (index = 0; index < abil_num; index = index + 1) BEGIN
READ_SHORT ("%abil_off%" + 0x1e + (0x28 * "%index%")) "abil_fx_num"
READ_SHORT ("%abil_off%" + 0x20 + (0x28 * "%index%")) "abil_fx_idx"
FOR (index2 = 0; index2 < abil_fx_num; index2 = index2 + 1) BEGIN
  READ_SHORT ("%fx_off%" +		(0x30 * ("%abil_fx_idx%" + "%index2%"))) "opcode"
  PATCH_IF ("%opcode%" = 240) BEGIN // remove icon opcode
	WRITE_BYTE ("%fx_off%" + 0x02 + (0x30 * ("%abil_fx_idx%" + "%index2%"))) 2 // target: preset target
  END
END
 END
 BUT_ONLY_IF_IT_CHANGES