PR: Refresh, non-stacking

[grodrigues]

The PR: Refreshing, non-stacking is up, fixing some (egregious) bugs in the patching code for EE. Since it does extensive surgery on two files, more pairs of eyes on it would be great.

[subtledoctor]

I agree that the 206 deletion is too indiscriminate, but it could simply have more matching parameters. Don’t really need to clone-then-delete. (And, without more matching parameters, the cloning might be too indiscriminate as well, adding unnecessary 321 effects.) 

But this may get to the same result, so maybe not worth the effort of quibbling. 

[Bartimaeus]

The end result of this running appears to have no effect? I installed this branch on a BG1EE game (e: and now a BG2EE game) and all 206s on all spells stay 206s instead of converting to 321s.

Edited September 9, 2021 by Bartimaeus

[grodrigues]

@BartimaeusMissing AUTO_EVAL_STRINGS so as not to have to intersperse EVAL's everywhere. But if I turn it on then the main component no longer installs barfing somewhere in the code that sets spell schools. Putting the PR on draft until I go over it again.

[grodrigues]

@BartimaeusNew, fixed PR is up. Tested and seems to be working now. Do note that accompanying the PR there is another PR with some more fixes, and without it, install will throw warnings -- by design.