State of BG2 Fixpack on Github?

[MikeX]

May I ask, what the actual state of the BG2 Fixpack on Github is?

It's a little bit confusing, the latest release is V13, but there are quite a few commits and a major overhaul since then in development, which, when downloaded is called V11.
Can/should this version being tested?

Also, I've found a little typo in 'core_item_bulk.tph, line 447':

    PATCH_IF (IS_AN_INT params_2) BEGIN // add/remove magical flag
      PATCH_IF (params_2 = 0)   BEGIN WRITE_BYTE 0x18 THIS & `BIT6 END // remove magical flag
      PATCH_IF (params_2 = 1)   BEGIN WRITE_BYTE 0x18 THIS | BIT6  END // add magical flag

There's a char in front of BIT6.

Thanks

Edited April 26, 2023 by MikeX

[argent77]

1 hour ago, MikeX said:

It's a little bit confusing, the latest release is V13, but there are quite a few commits and a major overhaul since then in development, which, when downloaded is called V11.

I agree that the name of the default git branch ("v11") is a bit misleading. It's normally called "master" or "main". But that's just an arbitrary name which has no impact on the mod content.

 

1 hour ago, MikeX said:

There's a char in front of BIT6.

That's intentional. The backtick (`) is a synonym for BNOT in WeiDU, which negates a bit state.

Edited April 26, 2023 by argent77

[MikeX]

2 hours ago, argent77 said:

I agree that the name of the default git branch ("v11") is a bit misleading.

Yes, I saw the major overhaul and restructuring and was wondering whether it's already in shape for testing or not.

2 hours ago, argent77 said:

That's intentional. The backtick (`) is a synonym for BNOT in WeiDU, which negates a bit state.

Ok, that makes perfect sense for the purpose it's used (to reset a bit), I should have looked closer.

It just caught my attention, because 'BIT6' was not highlighted by your excellent NPP highlighter...

[CamDawg]

Yeah, the main branch is named v11 because I essentially rewrote major portions of the code for v11, and then made that the main branch when v11 was released. I've never bothered to rename it because it doesn't really matter in the grand scheme of things.