[BG2 Tweaks] Combined components causing Beregost crash

[Ascension64]

~BG2_TWEAKS/SETUP-BG2_TWEAKS.TP2~ #0 #1210 // Use BG Walking Speeds (BETA): v7

~BG2_TWEAKS/SETUP-BG2_TWEAKS.TP2~ #0 #4020 // ToB-Style NPCs: v7

 

This install order corrupts corrupts _GARRIC[246].CRE, causing people to have crashes where Beregost fails to load (naturally, they use the Beregost Crash Fixer and of course it doesn't work). _GARRIC.CRE is unaffected.

 

I have no time to investigate further, but ToB-Style NPCs has difficulty catering for the extra effect added by the BG Walking Speeds component, either or both components could be culprits. I imagine there is a problem with the way offsets are being updated after the use of INSERT/DELETE_BYTES.

[erik]

I had a look now, and I'm having real trouble finding anything suspicious in the resulting cres. DLTCEP doesn't complain apart from ordering and the offsets look good to me. How do you tell they are corrupted?

 

Offset ordering has never killed anyone, has it? (head is simply a dump of the first longword of the offset. the walking speeds effect is inserted at the head of the list, so that change is expected.)

 

Plain easytutu soa-nototsc:

_GARRIC6.CRE : BG1/BG2 CRE V1.0
Known: off 724 num 4 head 1230458963
Spellmem: off 772 num 17 head 0
Rdyspell: off 1044 num 5 head 1230458963
Slots: off 1328 head 262143
Items: off 1248 num 4 head 1329748063
Effects: off 1104 num 3 head 233

 

same, w/the two components installed:

_GARRIC6.CRE : BG1/BG2 CRE V1.0
Known: off 724 num 4 head 1230458963
Spellmem: off 772 num 17 head 0
Rdyspell: off 1188 num 5 head 1230458963
Slots: off 1328 head 262143 tail 0
Items: off 1248 num 4 head 1329748063
Effects: off 1044 num 3 head 65712

[Ascension64]

NearInfinity reports holes and there are a number of corrupted effects on the creature that looks suspiciously like the offsets were not updated correctly.

 

Oh, and you could always try CLUAConsole:CreateCreature() in-game.

[erik]

Hmm. NearInfinity hates me (darn you, case-sensitiveness, darn you). DLTCEP says all is fine, effects on _garric6.cre look good there. And CreateCreature("_GARRIC6") works just fine with both components installed.

 

*puzzled*

 

Could you send me your corrupted cre, just for reference?

[Guest bg2tweaskfan1]

Hmm. NearInfinity hates me (darn you, case-sensitiveness, darn you). DLTCEP says all is fine, effects on _garric6.cre look good there. And CreateCreature("_GARRIC6") works just fine with both components installed.

 

*puzzled*

 

Could you send me your corrupted cre, just for reference?

 

Some more information and files about this can be found here:

 

http://www.shsforums.net/topic/24121-relea...post__p__478528

(That is the first post, the rest and some files can be found below it.)

[Ascension64]

Sorry for the late reply. Here are the files (BGT and Tutu are similarly corrupted - see http://www.shsforums.net/topic/24121-relea...mp;#entry484510 for file). Notice that effects 1 and 2 (i.e. 2nd and 3rd) are horribly corrupted in these files, even though the file offsets appear normal.

 

Only

~BG2_TWEAKS/SETUP-BG2_TWEAKS.TP2~ #0 #1210 // Use BG Walking Speeds (BETA): v7

~BG2_TWEAKS/SETUP-BG2_TWEAKS.TP2~ #0 #4020 // ToB-Style NPCs: v7

are installed.

[BelgarathMTH]

I am having the Beregost crash problem even with "change walking speeds" and "BG2-style npc's" not turned on.

 

There is more going on here.

 

I am currently finding Tutu unplayable on Windows7 with Tweaks installed, and maybe certain components of the NPC Project, because of the Beregost crash.

 

I never had this problem in years of playing on XP.

 

EDIT: Based on Ascension's clue about install order, I tried uninstalling every component of Tweaks and then reinstalling them one at a time. Surprise - the crash went away. This may be a possible workaround - if you get the crash, run Tweaks setup.exe and uninstall every component. Then reinstall it.

 

I haven't tested yet, but I have a hypothesis that Degreenifier may be involved in this problem.

 

EDIT: Hallelujah, Amen!! I just confirmed that installling the Degreenifier after Tweaks will cause the Beregost crash. To fix this particular cause, I only had to run uninstall in the Degreenifier .exe. It means that I will have to put up with green water, but at least I can play.

 

I do not know if I could have avoided this problem by installing Degreenifier first. It's too late to test that unless I start all over from scratch.

[Mike1072]

Fix (requires WeiDU v229+):

 

--- setup-bg2_tweaks.tp2	Sat May 01 09:49:47 2010
+++ setup-bg2_tweaks_new.tp2	Sat Mar 12 23:22:25 2011
@@ -3921,28 +3921,13 @@
 OR ("%anim%" = 0x6315)
 OR ("%anim%" = 0x6500)
 OR ("%anim%" = 0x6510)) BEGIN
-	READ_BYTE   0x33 "fx_type"
-	READ_LONG  0x2b0 "known_off"
-	READ_LONG  0x2b8 "slot_off"
-	READ_LONG  0x2bc "itm_off"
-	READ_LONG  0x2c4 "fx_off"
-	READ_LONG  0x2c8 "fx_num"
-	WRITE_LONG 0x2c8 ("%fx_num%" + 1)
-	PATCH_IF ("%known_off%" >= "%fx_off%") BEGIN
-	  WRITE_LONG 0x2b0 ("%known_off%" + (0x30 + (0xd8 * "%fx_type%")))
+	LPF ~ADD_CRE_EFFECT~
+	  INT_VAR
+		opcode = 176 // movement rate bonus
+		target = 1 // self
+		parameter1 = 0xfffffffd // -2 walking speed
+		timing = 9 // instant/permanent
 END
-	PATCH_IF ("%slot_off%" >= "%fx_off%") BEGIN
-	  WRITE_LONG 0x2b8 ("%slot_off%" + (0x30 + (0xd8 * "%fx_type%")))
-	END
-	PATCH_IF ("%itm_off%" >= "%fx_off%") BEGIN
-	  WRITE_LONG 0x2bc ("%itm_off%" + (0x30 + (0xd8 * "%fx_type%")))
-	END
-	INSERT_BYTES   ("%fx_off%"							  ) (0x30 + (0xd8 * "%fx_type%"))
-	  WRITE_SHORT  ("%fx_off%"		+ (0x08 * "%fx_type%"))		176 // movement rate bonus
-	  WRITE_BYTE   ("%fx_off%" + 0x02 + (0x0a * "%fx_type%"))		  1 // target: self
-	  WRITE_LONG   ("%fx_off%" + 0x04 + (0x10 * "%fx_type%")) 0xfffffffd // -2 walking speed
-	  WRITE_LONG   ("%fx_off%" + 0x0c + (0x10 * "%fx_type%"))		  9 // instant/permanent
-	  WRITE_LONG   ("%fx_off%" + 0x12 + (0x18 * "%fx_type%"))		100 // probability
  END
  BUT_ONLY_IF_IT_CHANGES