v35.6 english fallback for spell.tra

[mickabouille]

Hi, I think something similar already happened for a previous 35.x and was fixed (maybe with some other tra).

When trying to install component 2050 "IWD-inspired changes to BG(2) spells" in french, the install fails because @48 from spell.tra is not (yet) translated.

We will come to it (this failure let us know about those untranslated strings) but I think you said the english fallback was supposed to take place so I report it here.

 

I single-out 2050 but I suspect many other components below 2000 will have the same issue.

Edited January 10 by mickabouille

[Jazira]

Maybe something to do with the new acces path lang_som?

[mickabouille]

Really, can't really say. The code is beyond my deciphering abilities, too many indirections (I tried though)

[DavidW]

I’ll chase it (I’m working with a French install myself anyway because I’m trying to troubleshoot the language-related UI issues that have turned up in ToF.

[Jazira]

10 hours ago, DavidW said:

I’ll chase it (I’m working with a French install myself anyway because I’m trying to troubleshoot the language-related UI issues that have turned up in ToF.

Maybe we could provide some insights, what's the problem with ToF exactly?

[DavidW]

On 1/11/2024 at 5:33 PM, Jazira said:

Maybe we could provide some insights, what's the problem with ToF exactly?

I should have acknowledged this sooner - thanks for the offer. Basically, for its UI-based trickery to work ToF needs to know the active character's class and kit, but (as far as I could tell after a lot of exploration) that information is not directly exposed to the UI. The UI does know the name string of the character's kit, so I have code that recovers the kit ID (and thereafter the class ID) from that string. It worked fine in English in my testing environment, but it doesn't like accented characters, or non-alphanumeric symbols even in English-language kit descriptions (and it also fails if two kits have the same name, something I didn't anticipate being a problem but which actually came up quite quickly in the wild).

In the end, rather than fight complicated character-set-based battles with LUA regexps I went in a different direction. But I appreciate the offer.

[Jazira]

Alright, I'm afraid I could not help much.

Just in case, to replace accented characters or non-breaking space, it seems the following should work with Weidu regexps: "créatures" -> "cr[^a]+atures"

[DavidW]

OK, I can reproduce the original bug, and can fix it locally. Try this hotfix: open stratagems/sfo2e/lib_include.tph. Around line 112 there are two references to 'SFO_default_language'. Change them to 'sfo_default_language' (i.e., all lower case.)

[mickabouille]

I can confirm that yes, it seems to fix this issue, thanks.

 

But instead of just replacing the SFO_default_language on line 112, I also replaced one on line 97. Is that needed? Correct?

[DavidW]

It’s correct but not really needed - that bit of the code is just to avoid loading the tra files twice if you’re playing in the default  language, so I didn’t mention it in the hotfix.