MikeX

Thank you.

On 4/24/2024 at 2:28 AM, MikeX said:

carsa_add.baf, line 64:

        DisplayStringHead(Myself,%carsa_say_strref_8%)

Is there anything particular you had in mind for this, or is it just a missing string/strref?

Some component (Smarter Priests?) adds the unused string 'minimum_healing_level' to dialog.tlk.
Not an issue per se but maybe a hint that something is off elsewhere?

On 4/23/2024 at 8:28 PM, MikeX said:

SPWI101.spl:

Text "3 Phasen" / "3 turns" added to the end of the spell description

web_and_the_large.tpa, line 17:

        new:=@221

@22 -> @221

18 hours ago, Bartimaeus said:

Circumventing the start of BG2 taking away all of your items

You are right, I did not consider this.

Thank you, it works now.

5 hours ago, Bartimaeus said:

The player can find but cannot have two copies of the item: as mentioned in MikeX's post above, one HAMM04.itm is in BG1 (Ulgoth's Beard), and one HAMM04.itm is in BG2 (de'Arnise Keep...in the golem room, I think).

But in a BGT/EET game you can get two of them, can't you?

This is basically my main concern, two copies of what should be a unique item, but otoh it's not IR(R)s 'fault'.
IR(R) only changed what was already there and I'm fine with the item changes itself.

So, yes, it's not really within IR(R)s scope.
 

Sorry, i might not be clear enough.

I've just installed AI initialization and improved general AI (component 6000).
I think, 6000 creates all the npc scripts and many of them have 'DisplayStringHead' lines and these lines referencing an English strings from shared.tra on my German install.

Example from d1melas.bcs.

        DisplayStringHead(Myself,133241)  // *quaffs potion of magic protection*

@Bartimaeus

More of a question or clarification...

Regarding hamm04.itm:
TOSC added this unique item to a dwarf (Hurgan Stoneblade) in Ulgoth's Beard and you can get from him via dialog.
In TOB you can get it from somwhere around d'Arnise (just looked it up in NI).
So in a BGT game you could end up with two of them, of what should be unique.

IR(R) changed it to another unique item and I wonder, if the original could stay with Hurgan and the changed one to d'Arnise?

I know, you mentioned it before, that Demi did not care much about BG1, but maybe this could somehow be solved...

On 4/23/2024 at 8:28 PM, MikeX said:

General:
-Strings from shared.tra are installed in English although German is selected (e.g. *quaffs elixir of health*)

I don't know how much help it is, but only for a test, I added this (tra=shared):

BEGIN @61 DESIGNATED 6000 GROUP @6
REQUIRE_PREDICATE MOD_IS_INSTALLED "setup-stratagems.tp2" 5900 || IS_AN_INT stratagems_component_5900_installed @16025
REQUIRE_PREDICATE !GAME_IS iwdee @50009

LAF run STR_VAR files=genai location=genai tra=shared END

As expected, it fails when the only line from genai.tra, @217, is called, but installs the lines from shared.tra according to the selected language.
Is there somewhere a with_tra block missing?

@DavidW

Could you treat all the other items in this section like you did for enchantment = 1?
I mean, if already set different from 0 leave them alone.
I've checked my unmodded TOSC istallation and all but one had their enchantment set to 0, the only other one was already set to the right value.
That means, if enchantment for these items is already different from 0, another mod (e.g. IR(R)) changed it and one could assume, it knows what it was doing.

One example, IR(R) changed hamm04.itm to a +1 weapon and set enchantment accordingly , so enchantment = 4 would not be approbriate anymore.

Tested again with offical release v35.11, first post updated

I don't know, how helpful this will be, but here it is:

spell.tra:
-artifacts removed

General:
-Strings from shared.tra are installed in English although German is selected (e.g. *quaffs elixir of health*)

friendly_fiends_core.tpa, line 137:

        LAF return_detectable_string STR_VAR type="DW_POWER_UPGRADE_M1" RET string_low=string END
missing "

carsa_add.baf, line 64:

        DisplayStringHead(Myself,%carsa_say_strref_8%)
missing strref?

SPWI101.spl:

Text "3 Phasen" / "3 turns" added to the end of the spell description

stratagems_master, bg1fix.tpa, line 178:

Shoudn't it be :

                WRITE_LONG 0x60 (THIS=0)?1:THIS

0x64 -> 0x60

Once more, thank you for your continuous support.

On 3/13/2024 at 10:52 PM, Bartimaeus said:

The first one makes sense, since it's an EE-only item and I just over-looked it when transferring it over to IRR; the second one is the Equalizer. The last commit that I made to SW1H54.itm says "The Equalizer was usable by alignments it specifically mentioned as being denied to". The official IR description says "not usable by Lawful Good, Lawful Evil, Chaotic Good, Chaotic Evil"; the IRR description instead says it requires any kind of "neutral" alignment, which although different wording, should mean the same thing. Official IR's The Equalizer allows all alignments (including the supposedly barred Lawful/Chaotic Good/Evil) to use it, which I corrected for with the IRR version, but then I also added these 319s on top of that? I'm not certain why, especially because they're type 10 319s (restrict by character name?) and don't seem to actually reference anything. I'm a bit at a loss for what I was trying to accomplish here with these 319s...perhaps it was just left-over and unnoticed cruft from when I was trying to figure out how best to enforce the alignment restrictions? Regardless, thank you, I've fixed both swords!

@Bartimaeus
I've installed the latest IRR on a BGT game and it looks like the 319s on the Equalizer are still there.. Did I miss anything?

@dark0dave

I've tried this, because none of the other tools I'm aware of, has the option to take an existing weidu.log into consideration and skip already installed mods/components.
So, I've tried the option '--skip-installed', because I want to add some mods/components to the end of an existing install.
Unfortunately with this option set, I always get a fault from the first existing mod component, in my case:
...
thread 'main' panicked at src\mod_component.rs:30:32:
Could not find tp2 file, from: ~TOBEX/TOBEX.TP2~ #0 #100 // TobEx - Core: v28
...

I'm on Windows 10.
My batch file to launch mod_installer:

This is my current weidu.log (the install was created using mod_installer):

// Log of Currently Installed WeiDU Mods
// The top of the file is the 'oldest' mod
// ~TP2_File~ #language_number #component_number // [Subcomponent Name -> ] Component Name [ : Version]
~TOBEX/TOBEX.TP2~ #0 #100 // TobEx - Core: v28
~TOBEX/TOBEX.TP2~ #0 #101 // Apply Concentration Check On Damage [WIP]: v28
~TOBEX/TOBEX.TP2~ #0 #102 // Awaken On Damage: v28
~TOBEX/TOBEX.TP2~ #0 #103 // Blindness As Spell Description: v28
~TOBEX/TOBEX.TP2~ #0 #105 // No Spell Interruption On Zero Damage: v28
~TOBEX/TOBEX.TP2~ #0 #106 // Use Caster Level On Mirror Image [C]: v28
~TOBEX/TOBEX.TP2~ #0 #107 // Allow All Races to Dual Class: v28
~TOBEX/TOBEX.TP2~ #0 #108 // Allow Equipping Armor in Combat: v28
~TOBEX/TOBEX.TP2~ #0 #109 // Disable Experience Boost: v28
~TOBEX/TOBEX.TP2~ #0 #110 // Disable Force Inventory Pause: v28
~TOBEX/TOBEX.TP2~ #0 #111 // Disable Silence On Charm: v28
~TOBEX/TOBEX.TP2~ #0 #112 // Level One Proficiency Restrictions: v28
~TOBEX/TOBEX.TP2~ #0 #113 // Remain Hidden On Pickpocket Success [C]: v28
~TOBEX/TOBEX.TP2~ #0 #114 // Rest Spawns Advance Time: v28
~TOBEX/TOBEX.TP2~ #0 #115 // Dialogue Greeting Subtitles: v28
~TOBEX/TOBEX.TP2~ #0 #116 // Enable Animation Attack Sounds: v28
~TOBEX/TOBEX.TP2~ #0 #117 // Universal Four Inventory Weapon Slots: v28
~TOBEX/TOBEX.TP2~ #0 #118 // Subtitles For Standard Soundsets: v28
~TOBEX/TOBEX.TP2~ #0 #119 // Remove all race-class restrictions: v28
~TOBEX/TOBEX.TP2~ #0 #120 // Drop Inventory on Disintegrate: v28
~TOBEX/TOBEX.TP2~ #0 #121 // Drop Inventory on Frozen Death: v28
~TOBEX/TOBEX.TP2~ #0 #122 // Drop Inventory on Stone Death: v28
~TOBEX/TOBEX.TP2~ #0 #123 // Enable Auto-Pause On All Screens: v28
~TOBEX/TOBEX.TP2~ #0 #124 // Make All Attack Animations Genuine Attacks: v28
~TOBEX_AFTERLIFE/TOBEX_AFTERLIFE.TP2~ #0 #200 // TobEx AfterLife: v29.13
~TP/SETUP-TP.TP2~ #0 #0 // MKs BG2 Textpatch Revised: v3.4
~BG2FIXPACK/SETUP-BG2FIXPACK.TP2~ #3 #0 // BG2 Fixpack - Fehlerbehebungen: v13
~BG2FIXPACK/SETUP-BG2FIXPACK.TP2~ #3 #3 // BG2 Fixpack - BETA-Fehlerbehebungen (schaut bitte in die Readme!): v13
~BG2FIXPACK/SETUP-BG2FIXPACK.TP2~ #3 #100 // Gruppe bekommt Erfahrung, wenn sie Keldorn zu Maria schickt: v13
~BG2FIXPACK/SETUP-BG2FIXPACK.TP2~ #3 #101 // Verbesserte Zauberanimationen: v13
~BG2FIXPACK/SETUP-BG2FIXPACK.TP2~ #3 #103 // Dolche mit Nah- und Fernkampf korrigieren: v13
~BG2FIXPACK/SETUP-BG2FIXPACK.TP2~ #3 #104 // Ghreyfains Korrekturen der Heiligen Symbole: v13
~BG2FIXPACK/SETUP-BG2FIXPACK.TP2~ #3 #106 // Riesen erhalten Abzuege beim Angriff auf Halblinge, Zwerge und Gnome: v13
~BG2FIXPACK/SETUP-BG2FIXPACK.TP2~ #3 #107 // Mehrklassen-Beschraenkung fuer Bogenschuetzen und Pirscher entfernen: v13
~BG2FIXPACK/SETUP-BG2FIXPACK.TP2~ #3 #108 // Zweiten Attributsbonus fuer den boesen Weg bei den Hoellenpruefungen entfernen: v13
~BG2FIXPACK/SETUP-BG2FIXPACK.TP2~ #3 #109 // Korrigiertes Verhalten beschworener Daemonen: v13
~BG2FIXPACK/SETUP-BG2FIXPACK.TP2~ #3 #110 // Zusaetzliche Skripte korrigieren: v13
~BG2FIXPACK/SETUP-BG2FIXPACK.TP2~ #3 #111 // Berichtigte Bardenlieder: v13
~BG2FIXPACK/SETUP-BG2FIXPACK.TP2~ #3 #112 // Magierkiller verursachen "Magie fehlwirken" im Fernkampf: v13
~BG2FIXPACK/SETUP-BG2FIXPACK.TP2~ #3 #113 // Zusaetzliche Gesinnungen korrigieren: v13
~BG2FIXPACK/SETUP-BG2FIXPACK.TP2~ #3 #114 // Handlungsfreiheit schuetzt gegen Betaeubung: v13
~BG2FIXPACK/SETUP-BG2FIXPACK.TP2~ #3 #115 // Klauen der Gestaltwandler koennen nicht gebannt werden: v13
// Recently Uninstalled: ~BG2FIXPACK/SETUP-BG2FIXPACK.TP2~ #3 #116 // Zusatzpunkte auf Diebesfaehigkeiten von Barden und Waldlaeufern entfernen: v13
~BG2FIXPACK/SETUP-BG2FIXPACK.TP2~ #3 #116 // Zusatzpunkte auf Diebesfaehigkeiten von Barden und Waldlaeufern entfernen: v13

Mod_installer seems to can not install BGT, probably because at some point this mod expects the input of the path to the BG1 install.
So, I want to install it manually and than continue with the rest from this log file:

Any help on whether and how this can be achieved would be greatly appreciated.

Thanks again!

@Bartimaeus

Sorry to bother you again.
SR(R?) installs on a BGT game SPIN733.SPL with EE only Opcode 324.

@Bartimaeus

Thank you!

@Bartimaeus

IR(R?) installs on a BGT game OHSW1H55.ITM (appears to be unused) and SW1H54.ITM with EE only Opcode 319.

On 5/26/2023 at 4:00 PM, NdranC said:

According toNearInfinity the only illegal store item is bernard's and it's WIZARD_S.ITM

 

This looks like an unresolved item ('WIZARD_SCROLL_...') installed by SCS...

2 hours ago, argent77 said:

I agree that the name of the default git branch ("v11") is a bit misleading.

Yes, I saw the major overhaul and restructuring and was wondering whether it's already in shape for testing or not.

2 hours ago, argent77 said:

That's intentional. The backtick (`) is a synonym for BNOT in WeiDU, which negates a bit state.

Ok, that makes perfect sense for the purpose it's used (to reset a bit), I should have looked closer.

It just caught my attention, because 'BIT6' was not highlighted by your excellent NPP highlighter...

May I ask, what the actual state of the BG2 Fixpack on Github is?

It's a little bit confusing, the latest release is V13, but there are quite a few commits and a major overhaul since then in development, which, when downloaded is called V11.
Can/should this version being tested?

Also, I've found a little typo in 'core_item_bulk.tph, line 447':

    PATCH_IF (IS_AN_INT params_2) BEGIN // add/remove magical flag
      PATCH_IF (params_2 = 0)   BEGIN WRITE_BYTE 0x18 THIS & `BIT6 END // remove magical flag
      PATCH_IF (params_2 = 1)   BEGIN WRITE_BYTE 0x18 THIS | BIT6  END // add magical flag

There's a char in front of BIT6.

Thanks

1 hour ago, argent77 said:

Ability descriptions will be made available in the next version of the mod for all games.

Thank you very much.
Could you please also include the current necessary hotfix mentioned earlier in this thread?

14 hours ago, argent77 said:

Is that a new TobEx feature? Normally you can't open the description for innate abilities in the original games

Yes it is, with this:

~BG2IMPROVEDGUI\BG2IMPROVEDGUI.TP2~ #0 #3000 // Innate/Ability/Spell Description Screen on Right Click (includes Icon/Item Abilities/Tooltip fixes and Innate/Ability text update by Prozh): 5.5

But neverthless it wouldn't hurt (I think) to see the description at least in NI...