A script block in baldur.bcs meant for the BG2 portion can execute in BG1

[Enkidu]

In the vanilla BG2EE and EET baldur.bcs we have this:

IF
    OR(2)
        Global("PCSphere","GLOBAL",2)
        ReputationLT(Player1,4)
    GlobalLT("BribedCowled","GLOBAL",2)
THEN
    RESPONSE #100
        SetGlobal("BribedCowled","GLOBAL",2)
END

I think this is supposed to happen only in the bg2 portion of the game. BG2EE V2.6.6.0 with EET V13.4. I don't remember any such block in the old non-EE BG2. Was this added in the EE or was it always there?

[jastey]

This block is in classic BG2:ToB, too.

EDIT: And I agree that it can execute in Bg1, too. The question is, whether this would be against the original intention, since a group with a rep lower than 4 is clearly meant to have this variable set.

[Enkidu]

The reason I think this should not execute in the BG1 portion is that cowled wizards play no role in that game. It's the same reason that your reputation resets when you  transition to BG2.

Edited August 11, 2022 by Enkidu

[jastey]

Yes, I see the point. EET should add Global("EndOfBG1","GLOBAL",2) to that script block. Unless EET handles the situation differently since there is bgbaldur.bcs and bdbaldur.bcs in EET, too. I'm not sure whether baldur.bcs is the one valid for all games or just BG2? I know that I add mod added script blocks to the game specific bg/bd/baldur.bcs scripts, I just don't know what EET_End does with regard to merging in the end.

It's the same for BGT btw, it isn't tagged there, either.

[Enkidu]

I noticed this block after it executed in my game while I was still in BG1, so baldur.bcs is definitely running in BG1.

[jastey]

OK, makes sense that EET unifies it.

[Graion Dilach]

That needs to be prepatched during EET install (and not EET_End). I'll file a PR.

[Graion Dilach]

Filed/fixed in https://github.com/Gibberlings3/EET/pull/77. Fix is also cherrypicked to the graion-all-in branch in my fork.

[mickabouille]

@Graion DilachMaybe that's intentional (in that case please ignore me), it seems your fork master is not up to date with K4thos' master, but rather with their v13.4 tag.

[Graion Dilach]

It was never intentional (at one point I had issues with HTTPS git connections and had to fall back to SSH connections which led me to lose sync with remotes, I presume this repo was also affected), but the French translation wouldn't affect any of my direct bugfixes anyway. I've fixed this locally however and rebased the graion-all-in branch to include the translation fixes in that one. Thanks!

[Enkidu]

I have recently made a new EET install with the new EET master. The issue is still not fixed. Baldur25.bcs has the fixed script block but baldur.bcs doesn't.