[BUG v16] Unique Icons makes flaming fist helms green on BG:EE

[agris]

on BG:EE, if component 170 "Unique Icons [Lava] -> Only replace icons that aren't already unique: v16" is installed after ~NOSTALGIAPACK/NOSTALGIAPACK.TP2~ #0 #60 // Restore BG1 Flaming Fist appearance: RC4, Flaming Fist NPCs' helms are green.

 

Flaming Fist mercenaries are equipped with HELM09.itm, which has a conspicuous color code for the helm set to green. Running a --change-log on HELM09.itm shows that nostalgiapack unbiffed and modified it, followed only by cdtweaks 170. The version that nostalgiapack generated does not have the green code.

weidu.log, change-log output, and both versions of the itm file attached.

 

_helm09 bug.7z

[agris]

Another oddity of Nostalgia Pack helmets being borked by Lava's unique icons. On BG:EE, Nostalgia Pack Component 50 "Restore BG1 Icon Icons and Appearances" created or unbiffed helm11.itm. Lava's component 170 modifies it to change the icon and the paperdoll appearance, but the new appearance isn't valid.

This is the helm after Lava's modification of the ITM's appearance field to "h6".

 

The nostalgiapack version used h5, which renders correctly.

[Morgoth]

Planning to use Nostalgia Pack and saw this. Have you found a way to fix these issues?

 

[Graion Dilach]

The first "issue" looks intentional to me and can be fixed easily via installing the "use character colors instead of item colors" component after Unique Icons.

The second issue might be a bug with Nostagia Pack's BG1 paperdolls? That would need a weidu.log to know what one should look at.

[Jarno Mikkola]

13 minutes ago, Graion Dilach said:

.. That would need a weidu.log to know what one should look at.

Are you aware that the --change-log will give you that, and also responsiple components. Well, for the item. The attached archive also has the general weidu.log ... what I see is that the paperdolls transparency color palette has likely the wrong color order. Aka the orange should be transparent. Easy to fix... recolor the orange color spots to be the second color in the palette.

[CamDawg]

This is a bug in Tweaks itself; Nostalgia Pack just makes it a little more visible. The green color is supposed to be applied to the plume, not the helmet itself and would be an issue it you used the 'Replace All Icons' option.

You only see it here with Nostalgia + Don't Replace because Nostalgia reverts the helmet's unique icon back to the same icon as the Helm of the Noble, which in turn prompts Tweaks to change it since it's no longer unique.

[CamDawg]

For the second issue (helm11) I'm unable to repro with this + NP. H6 is a valid paperdoll selection for helmets and works with or without Tweaks installed. I've tried various ways to order the components from NP and Tweaks with no avail.

That aside, you probably still shouldn't install stuff that modifies paperdolls with this anyway. Helmets, in particular, expect that certain assignments have horns or plumes or whatever and these changed between the BG and BG2/EE models. Unique Icons will assign a helmet appearance that (on normal paperdolls) best matches the icon, and will do a poor job if the underlying paperdoll has been reverted to BG models.

[Morgoth]

On 10/22/2023 at 11:08 PM, CamDawg said:

That aside, you probably still shouldn't install stuff that modifies paperdolls with this anyway. Helmets, in particular, expect that certain assignments have horns or plumes or whatever and these changed between the BG and BG2/EE models. Unique Icons will assign a helmet appearance that (on normal paperdolls) best matches the icon, and will do a poor job if the underlying paperdoll has been reverted to BG models.

I'm reading this comment now - to which mod is "with this anyway"? 

By the way, also take a look at this, for anyone interested in the mod

and this: https://github.com/SpellholdStudios/Nostalgia-Pack/issues/2#issuecomment-1891069498

Edited January 14 by Morgoth