New translation (please update!)

[Austin]

Hello! Staylos, Apxu & Arcanecoast Team translated this mod into Russian. Please add the translation to the new version!

 

RE v.7 russian.rar

Edited July 21, 2021 by Austin

[jastey]

Thanks, I'll add the translation when I'll have the time.

[Graion Dilach]

Would it be helpful if I'd file this as a PR? (Just trying to assist here.)

[jastey]

@Graion Dilach I'm won't say no to that!

Funnily enough, my Windows Defender is detecting a virus in the attached package above, I already contacted @Austin. Not saying that I think there is one inside, but apparently something that ticks off WD for some reason.

[Austin]

13 hours ago, jastey said:

Funnily enough, my Windows Defender is detecting a virus in the attached package above, I already contacted @Austin. Not saying that I think there is one inside, but apparently something that ticks off WD for some reason.

I repackaged the files and PM them in a different format) Also I uploaded them in the first post again!

Edited July 21, 2021 by Austin

[Graion Dilach]

Filed https://github.com/Gibberlings3/BG1_Romantic_Encounters/pull/8

@jastey I didn't touched the version numbers in the PR, but if you want to, I can bump the version number along to 7.1 or 8 in a followup commit/fixup action within the PR and then you can tag the merge as a new version imminently.

[jastey]

@Graion Dilach thank you! I changed the version number myself.

@AL|EN why does the new mod package name state "7.0"? (Link) It should be 8.0; 7.0 was the version earlier.

[Graion Dilach]

It wasn't changed in the tp2 - https://github.com/Gibberlings3/BG1_Romantic_Encounters/blob/master/bg1re/setup-bg1re.tp2#L10 - and IAP picks it up from there.

[jastey]

Oh wow, I forgot to PR the last change. Thanks for spotting that.

How do I reassign the Automated Packaging Tool so it will repack?

[Graion Dilach]

I tend to delete the tag, and then recreating but this is something which is against the doc.

[jastey]

I just created a new one 8.1.

[AL|EN]

Yep, manually manipulation the tags after release (even the faulty one) is asking for a trouble. Just follow standard release process and everything will be fine.

[Graion Dilach]

@AL|EN Considering how many times this comes up lately... wouldn't it be better if IAP would receive an option to set the tp2 VERSION during packaging, derived from the tag somehow? That would massively decrease the error margin.

[AL|EN]

@Graion Dilach But that's the whole point, can't you see it? Do you know how many times tp2 version wasn't updated during new release and the 'I'm installing version x but the wierdu.log gives me version y' ping-pong happen?

IAP allows you to spot it after release, "Mod Release" commandline tool will prevents releasing faulty version in the first place (agree that setting it up is painful).

[Graion Dilach]

@AL|EN I find the opposite of your workflow more logical and elegant. In your workflow, you derive the git tag from the tp2 version string and your proposal necessitates one to have a local automation to prepare for the packaging automation. What I'm proposing is to derive the version string from the git tag instead. This is less invasive to a personal workflow (because it does not need any local preparation step or a separate tool) at the cost of a more complicated packaging automation and at the possibility of introducing a difference between the source (having a placeholder version string) and the packaged version (which, considering how much you favor anti-tampering mechanisms, might be even a bonus to you). You can look at OpenRA to see how that works in practice (and it works well there because this mindset was deployed in 2015, got copied into the official ModSDK at it's start in 2017 and over the years I never heard anyone ending up with a wrongly tagged release when proper tagging is relevant there because differently tagged builds are not multiplayer-compatible).

Also, you're using your lecturing tone again. I don't like that.