The new Fixpack thread for Compatibility, Bug Reporting, Changing/Removing Fixes

[Thermalcarbonblack]

Question:

In "Optional But Cool Components" description (both on webpage and in readme) in "Additional Script Fixes" paragraph it says: "A more detailed account of the changes can be found in the full Optional But Cool documentation."  But the hyperlink leads to "Game Mechanics Fixes" (core component) description page. Am I missing something? Where can I read about script fixes from OBC?

[CamDawg]

Heh, I thought this documentation was something that got lost in the move to the new host, but it looks like I never wrote it. I'll get to work.

[CamDawg]

For the main and GTU components: correct references to Arvoreen to reflect that he's a he, not a she.

[CamDawg]

On 1/7/2022 at 10:14 AM, CamDawg said:

Heh, I thought this documentation was something that got lost in the move to the new host, but it looks like I never wrote it. I'll get to work.

For the record, the Fixpack OBC page now has documentation for all of the OBC components.

[Andrea C.]

No idea how reliable this is, but Edwin's Wiki page states, "Conflicts (the script for a fight is present in the game's code, but the related dialogue lacks the trigger, which means Edwin and Valygar won't actually fight)"

Perhaps it might be worth fixing (unless it is already.)

[CamDawg]

It looks like this is the banter:

• Valygar (bvalyga state 41): You remind me more and more as each day passes of what makes magic vile and evil, wizard. 
• Edwin: You would do well to be reminded of what makes magic powerful, fool.  I've power enough to hold your life in my hands if I choose.
• Valygar: Your words do not frighten me, Edwin.  I could slice you to ribbons before the first incantation of your threat was carried out.
• Edwin: Indeed?  Your lack of fear for the arcane arts must explain, then, why you cowered before Lavok and the Cowled Wizards.  Your actions belie your bravado.
• Valygar: I cower before nothing!  I merely showed caution before approaching Lavok...someone possessing far more power than you!
• Edwin: You call that caution?  Quivering in a forest?  Lavok could have dealt with you in a second, if he chose.  And it would only take me a second longer.
• Valygar: We shall see!

It just ends there (bvalyga state 44). There is, as you say, full scripting for a fight triggered by EdwinValygarFight = 1. which could be set here. Ironically, Tweaks' Happy Patch disables this fight, even though it never happened.

I guess the real question is whether this is Fixpack or UB.

[jastey]

my opinion: If this something that can be fixed with a typo correction (like, wrong DV was used etc.) -> Fixpack.

If it's traces in the dialog.tlk / dlg files that was reconstructed -> UB.

[Jarno Mikkola]

27 minutes ago, jastey said:

If it's traces in the dialog.tlk / dlg files that was reconstructed -> UB.

But problem is that the Valygar's dialog response(We shall see! ) just doesn't set the state that it should(thus easy -fix), that then makes them hostile to one another. So Fixpack is my oppinion. And the Happy patch should stay as is. Unless it needs an update, but it shouldn't.

Edited February 15, 2022 by Jarno Mikkola

[Guest Graion@Work]

UB.

[Salk]

Valygar and Edwin there do sound like they have unfinished business... 

But I actually agree here with the Imp: it seems like this belongs to the Fixpack.

[CamDawg]

The Light Crossbow icon fix. Affects pretty much every game, including the EEs.

[Andrea C.]

1 hour ago, CamDawg said:

The Light Crossbow icon fix. Affects pretty much every game, including the EEs.

Been bugging me forever. Kudos for the fix!

[CamDawg]

A very old Yoshimo banter bug.

[CamDawg]

Also Galoomp sells duplicate scrolls of Emotion.

[Dan_P]

Minsc's Berserk ability (spin117)

Pretty minor, but some of the opcode 267's (disable display string) are set to a duration of 30 instead of 120.